Rename and update NPC Heal/Raise config setting #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `_friendlyPartyNPCHealRaise` to `_friendlyPartyNPCHealRaise2` and changed its default value from `true` to `false`. Updated the description to indicate that it is experimental and may cause issues in some fights. Updated all references in `DataCenter.cs`, `ObjectHelper.cs`, and `RotationConfigWindow.cs` to use the new setting name. Modified the UI text and button functionality in `RotationConfigWindow.cs` to reflect the new setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
_friendlyPartyNPCHealRaiseto_friendlyPartyNPCHealRaise2and changed its default value fromtruetofalse. Updated the description to indicate that it is experimental and may cause issues in some fights. Updated all references inDataCenter.cs,ObjectHelper.cs, andRotationConfigWindow.csto use the new setting name. Modified the UI text and button functionality inRotationConfigWindow.csto reflect the new setting.