TTK, Ability checks, Raise logic adjustments #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated subproject commit to e746021d184cf53e7cbab228e326ffdd5f5c4d3e. BaseAction.cs: - Added logic to use new V2 ability checks based on config option. - Introduced IsLastAbilityv2Usable and IsFirstAbilityv2Usable methods. Configs.cs: - Added _useV2AbilityChecks configuration option. DataCenter.cs: - Added LastAbilityv2 and FirstAbilityv2 properties for new simplified oGCD timer checks. ObjectHelper.cs: - Renamed variables for clarity. - Changed recordedHPCopy from List to Array for performance. - Refactored health ratio and elapsed time calculations to attempt to fix early TTK calculations. RotationConfigWindow.cs: - Added debug info for LastAbilityv2 and FirstAbilityv2.
- Added `SteelPeakPvE` action in `MNK_Default.cs` for lower level support. - Introduced `_enableClickingCount` option in `Configs.cs` for RSR click counter, allowing users to disable it if they want. - Replaced `SortedList` with `Dictionary` in `ObjectListDelay.cs` and simplified `Random` initialization. - Updated `LastAbilityv2` and `FirstAbilityv2` conditions in `DataCenter.cs` to include additional checks. - Increased `QUEUECAPACITY` for actions and damages in `DataCenter` from 16 to 32. - Moved `RaiseSpell` logic in `CustomRotation_GCD.cs` to ensure RSR prioritizes keeping people alive over rezing. - Made `ClickingCount` increment conditional in `RSCommands_Actions.cs` based on `_enableClickingCount`. - Added "GCD Cooldown Visualization" section in `RotationConfigWindow.cs` with progress bar and markers. - Removed unused `Action` import in `Watcher.cs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add V2 ability checks and refactor code for clarity
Updated subproject commit to e746021d184cf53e7cbab228e326ffdd5f5c4d3e.
BaseAction.cs:
Configs.cs:
DataCenter.cs:
ObjectHelper.cs:
RotationConfigWindow.cs:
Enhance action handling and add new configuration options
SteelPeakPvEaction inMNK_Default.csfor lower level support._enableClickingCountoption inConfigs.csfor RSR click counter, allowing users to disable it if they want.SortedListwithDictionaryinObjectListDelay.csand simplifiedRandominitialization.LastAbilityv2andFirstAbilityv2conditions inDataCenter.csto include additional checks.QUEUECAPACITYfor actions and damages inDataCenterfrom 16 to 32.RaiseSpelllogic inCustomRotation_GCD.csto ensure RSR prioritizes keeping people alive over rezing.ClickingCountincrement conditional inRSCommands_Actions.csbased on_enableClickingCount.RotationConfigWindow.cswith progress bar and markers.Actionimport inWatcher.cs.