Refactor PrioTarget system and enhance various functionalities #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced PrioTargetNames with PrioTargetId HashSet across the codebase, updating initialization, saving, and resetting methods. Improved DataCenter's IsCastingVfx method to avoid modifying collections during enumeration. Extended IActionHelper with IsLastActionGCD and IsLastActionAbility methods. Updated ObjectHelper to remove PrioTargetNames logic and enhance ChooseAttackMark condition. Enhanced PriorityTargetHelper to handle priority target IDs via JSON. Updated solution file to include PrioTargetId.json. Refined UiString and RotationConfigWindow for new target priority system. Improved MajorUpdater's VfxNewData handling. Added PrioTargetId.json for storing priority target IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes aimed at improving the prioritization system, refactoring the configuration handling, and enhancing the user interface. The most important changes include the replacement of prioritized target names with prioritized target IDs, the addition of new helper methods, and updates to the UI to reflect these changes.
Prioritization System Updates:
RotationSolver.Basic/Configuration/OtherConfiguration.cs: ReplacedPrioTargetNameswithPrioTargetIdand updated relevant methods to handle the new priority target IDs. [1] [2] [3] [4] [5]PrioTargetId.json: Added a new JSON file to store priority target IDs.Helper Methods:
RotationSolver.Basic/Helpers/IActionHelper.cs: Added new methodsIsLastActionGCDandIsLastActionAbilityto determine the type of the last action.RotationSolver.Basic/Helpers/PriorityTargetHelper.cs: Refactored to load priority OIDs from a JSON file and save changes when a new priority target is added. [1] [2]UI Enhancements:
RotationSolver/UI/RotationConfigWindow.cs: Updated the UI to remove the old prioritized target names section and added new UI elements for managing priority target IDs. [1] [2] [3]RotationSolver/UI/RotationConfigWindow_Config.cs: Added a new section for managing target priorities in the configuration window. [1] [2] [3]Miscellaneous:
RotationSolver/Data/UiString.cs: Updated descriptions and added new strings for the UI changes. [1] [2]RotationSolver.sln: Updated the solution file to include the newPrioTargetId.jsonfile. [1] [2]