Changes to MNK, BRD, and chat feedback #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the rotation configurations for the Monk and Bard classes, as well as some updates to the chat feedback functionality and configuration descriptions. The most important changes include adding a new configuration option for the Monk class, modifying the logic for using certain abilities, updating game version references, and enhancing chat feedback for toggled actions.
Rotation Configuration Updates:
BasicRotations/Melee/MNK_Default.cs: Added a new configuration optionHowlingSingleto control the use of Howling Fist as a ranged attack against single target enemies.BasicRotations/Melee/MNK_Default.cs: Modified the logic inGeneralGCDto respect the newHowlingSingleconfiguration when using Howling Fist.BasicRotations/Ranged/BRD_Default.cs: Updated the condition for using Empyreal Arrow to include a check for the cooldown status of Raging Strikes.Game Version Updates:
BasicRotations/Melee/MNK_Default.cs: Updated the game version reference from7.00to7.15in the rotation attribute.BasicRotations/Ranged/BRD_Default.cs: Updated the game version reference from7.11to7.15in the rotation attribute.Chat Feedback Enhancements:
RotationSolver/Commands/RSCommands_OtherCommand.cs: Added logic to print feedback in chat when a setting is toggled, based on theShowToggledActionInChatconfiguration. [1] [2]RotationSolver.Basic/Configuration/Configs.cs: Updated the description for theShowToggledActionInChatconfiguration to clarify its purpose.