Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out Howling Fist and Enlightment usage at range #487

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

LTS-FFXIV
Copy link
Member

This pull request includes several changes to the MNK_Default class in the BasicRotations/Melee directory, focusing on the usage of the Howling Fist and Enlightenment abilities. Additionally, there is an update to the ECommons subproject commit reference.

Key changes:

Ability Usage Adjustments:

  • Modified the HowlingSingle property to include Enlightenment alongside Howling Fist for ranged attacks against single target enemies and set its default value to true (BasicRotations/Melee/MNK_Default.cs).
  • Simplified the AttackAbility method by removing the conditional check for the number of hostiles and ensuring Enlightenment and Howling Fist are used regardless of the number of enemies (BasicRotations/Melee/MNK_Default.cs).
  • Updated the AttackAbility method to use Enlightenment and Howling Fist with the skipAoeCheck parameter based on the HowlingSingle property (BasicRotations/Melee/MNK_Default.cs).

General Cleanup:

  • Removed redundant checks and usage of Enlightenment and Howling Fist in the GeneralGCD method (BasicRotations/Melee/MNK_Default.cs).

Subproject Update:

  • Updated the ECommons subproject commit reference to a new commit (ECommons).

@LTS-FFXIV LTS-FFXIV merged commit af9185d into main Dec 23, 2024
@LTS-FFXIV LTS-FFXIV deleted the mnkHowling branch December 23, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant