Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switch for Riddle of Fire usage #489

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Added switch for Riddle of Fire usage #489

merged 1 commit into from
Dec 24, 2024

Conversation

LTS-FFXIV
Copy link
Member

This pull request introduces several enhancements and fixes to the BasicRotations/Melee/MNK_Default.cs file, including the addition of new configuration options and improvements to ability handling logic. Additionally, it updates the ECommons subproject commit reference.

Enhancements and Configurations:

  • Added a new enum RiddleOfFireFirst to specify the ability to use before Riddle of Fire with options for Brotherhood and Perfect Balance.
  • Introduced a new configuration option ROFFirst to set the preferred ability to use before Riddle of Fire.

Ability Handling Improvements:

  • Modified the EmergencyAbility method to use the new ROFFirst configuration for determining the ability to use before Riddle of Fire.
  • Added a new GeneralAbility method to handle the use of Earth's Reply when the status EarthsRumination is about to end.
  • Updated the HealAreaAbility method to prioritize the use of Earth's Reply before Mantra.

Subproject Update:

  • Updated the ECommons subproject commit reference to the latest commit.

@LTS-FFXIV LTS-FFXIV merged commit aaab732 into main Dec 24, 2024
@LTS-FFXIV LTS-FFXIV deleted the RiddleOfFire branch December 26, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant