Fix redundant checks on MNK causing delays for Masterful Blitz variant uses, added option to BRD to preserve the use of esuna for self #492
+31
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
BasicRotations
module, focusing on improving the Monk and Bard rotations. The most important changes include adjustments to ability conditions, the addition of new configuration options, and the removal of unnecessary parameters.Monk Rotation Adjustments:
BasicRotations/Melee/MNK_Default.cs
: Modified the conditions for usingEarthsReplyPvE
,BrotherhoodPvE
, and other abilities to ensure they are used more effectively. RemovedskipAoeCheck
parameter where it was unnecessary. [1] [2] [3]RotationSolver.Basic/Rotations/Basic/MonkRotation.cs
: AddedAoeCount
to several action settings to better handle AoE scenarios. [1] [2] [3] [4]Bard Rotation Enhancements:
BasicRotations/Ranged/BRD_Default.cs
: Introduced a new configuration optionBRDEsuna
to allowWarden's Paean
to be used on other players, improving the flexibility of the Bard's dispel ability. [1] [2]General Code Cleanup:
BasicRotations/Melee/MNK_Default.cs
: Removed unusedusing
directive forDefaultRotations.Magical.SMN_Default
.