Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to MNK chakra usage, fixes to DRK delirium combo #493

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

LTS-FFXIV
Copy link
Member

This pull request includes several changes to the BasicRotations module, focusing on the Melee and Tank classes, as well as an update to a subproject commit. The most important changes include adding new abilities to the MNK_Default rotation, updating the DRK_Default rotation logic, and modifying the game version and source code path for the DRK_Default class.

Changes to MNK_Default rotation:

  • Added EnlightenmentPvE and HowlingFistPvE abilities to the AttackAbility method.
  • Adjusted the conditions for using EnlightenmentPvE and HowlingFistPvE abilities when HowlingSingle is true.

Changes to DRK_Default rotation:

  • Updated the game version to "7.15" and corrected the source code path in the DRK_Default class definition.
  • Refined the GeneralGCD method to include new AOE logic and adjusted conditions for using SouleaterPvE, SyphonStrikePvE, and HardSlashPvE abilities based on DeliriumStacks and LowDeliriumStacks.

Other changes:

  • Updated the subproject commit for ECommons.
  • Removed action checks for ScarletDeliriumPvE, ComeuppancePvE, and TorcleaverPvE in DarkKnightRotation.

@LTS-FFXIV LTS-FFXIV merged commit e12022c into main Dec 27, 2024
@LTS-FFXIV LTS-FFXIV deleted the DRKfixes branch December 28, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant