delirium core fixes, verified rotation no longer hangs #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes enhancements to the Dark Knight rotation logic in
DRK_Default.csandDarkKnightRotation.cs. The changes focus on improving the handling of Delirium status and adjusting action checks for various abilities.Enhancements to Delirium handling and action checks:
BasicRotations/Tank/DRK_Default.cs: Reorganized the GCD logic to better handle Delirium status and added new action checks forDisesteemPvE,ComeuppancePvE, andScarletDeliriumPvE. [1] [2]RotationSolver.Basic/Rotations/Basic/DarkKnightRotation.cs: Introduced new properties such asHasDelirium,ScarletDeliriumReady,ComeuppanceReady,TorcleaverReady, andImpalementReadyto streamline action checks.RotationSolver.Basic/Rotations/Basic/DarkKnightRotation.cs: Updated theDisplayStatusmethod to include the new properties for better debugging and status display.RotationSolver.Basic/Rotations/Basic/DarkKnightRotation.cs: Modified action settings forScarletDeliriumPvE,ComeuppancePvE,TorcleaverPvE, andImpalementPvEto use the new properties and ensure proper action execution. [1] [2]