Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft refactor of SAM to align with rewrite #499

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Soft refactor of SAM to align with rewrite #499

merged 1 commit into from
Dec 31, 2024

Conversation

LTS-FFXIV
Copy link
Member

This pull request includes several changes to the SAM_Default class in the BasicRotations/Melee directory. The changes focus on improving code readability and updating default configuration settings.

Configuration Updates:

  • Changed the default value of HiganbanaTargets to true to prevent Higanbana use if there is more than one target.

Code Readability Improvements:

  • Renamed variables from IsTargetBoss and IsTargetDying to isTargetBoss and isTargetDying for consistency with camelCase naming conventions. [1] [2] [3] [4]
  • Replaced square brackets with curly braces in the SamBuffs array initialization for better readability.
  • Other misc general fixes.

@LTS-FFXIV LTS-FFXIV merged commit 706ffaf into main Dec 31, 2024
@LTS-FFXIV LTS-FFXIV deleted the ShadowWalker branch December 31, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant