Add checks to PvE methods and update online status handling #506
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks in AstrologianRotation.cs and CustomRotation_Actions.cs to ensure specific actions are not the last used before proceeding. Updated RotationConfigWindow.cs to display player's online status. Modified TargetUpdater.cs to exclude characters with an online status of 5 in filtering logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
RotationSolverproject, focusing on enhancing action settings and improving status checks. The most important changes include modifications to action settings in theAstrologianRotationandCustomRotation_Actionsfiles, updates to theDrawStatusmethod in theRotationConfigWindowfile, and refinements to theGetPartyMembersandGetAllianceMembersmethods in theTargetUpdaterfile.Enhancements to action settings:
RotationSolver.Basic/Rotations/Basic/AstrologianRotation.cs: ModifiedModifyCombustPvEto include anActionCheckthat ensures the action is not the last ability used.RotationSolver.Basic/Rotations/CustomRotation_Actions.cs: UpdatedModifyTrueNorthPvEto add anActionCheckthat verifies the action is not the last one performed.Improvements to status checks:
RotationSolver/UI/RotationConfigWindow.cs: Enhanced theDrawStatusmethod to display the player's online status.RotationSolver/Updaters/TargetUpdater.cs: Refined theGetPartyMembersmethod to exclude characters with an online status of 5 from the list of targetable party members.RotationSolver/Updaters/TargetUpdater.cs: Adjusted theGetAllianceMembersmethod to also exclude characters with an online status of 5 from the list of targetable alliance members.