Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BLM and SAM classes with new options and logic #515

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

LTS-FFXIV
Copy link
Member

This pull request includes several changes to the BasicRotations module, focusing on the Magical and Melee rotations. The key changes involve updating game versions, modifying rotation configurations, and adjusting ability checks and descriptions.

Updates to Magical Rotations:

  • Game Version Update:

    • Updated the GameVersion attribute in BLM_Default class from "7.01" to "7.15".
  • Configuration Changes:

    • Added new configuration options LeylineMadness and Leyline2Madness for using Leylines in combat.
    • Re-added the UseRetrace configuration with a new description.
  • Ability Checks:

    • Modified GeneralAbility method to include checks for LeylineMadness and UseRetrace abilities.

Updates to Melee Rotations:

  • Enum and Configuration Updates:

    • Renamed MidareSetsugekka to Setsugekka in the STtoAOEStrategy enum and updated related configurations and descriptions. [1] [2]
  • General Ability Logic:

    • Adjusted the GeneralGCD method to prioritize TendoSetsugekkaPvE and KaeshiSetsugekkaPvE abilities more effectively. [1] [2]

General Configuration:

  • Description Update:
    • Updated the description for the _autoBurst configuration to clarify its purpose.

Additional Changes:

  • Black Mage Rotation Settings:
    • Set IsFriendly to true for LeyLinesPvE and RetracePvE actions. [1] [2]

Updated GameVersion in BLM_Default to 7.15. Added LeylineMadness and Leyline2Madness options and updated GeneralAbility method accordingly. Modified RotationDesc to include LeyLinesPvE and RetracePvE. Renamed Midare Setsugekka to Setsugekka in SAM_Default and updated related logic. Changed description of _autoBurst in Configs. Set IsFriendly to true in ModifyLeyLinesPvE and ModifyRetracePvE methods.
@LTS-FFXIV LTS-FFXIV merged commit 7fa01e7 into main Jan 2, 2025
@LTS-FFXIV LTS-FFXIV deleted the SAM512 branch January 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant