Bunchafixes #516
Merged
Bunchafixes #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated .gitignore to include Resources/AutoStatusOrder.json. Moved AutoStatusOrder to OtherConfiguration as HashSet<uint>. Added new config options _autoOffWhenDeadPvP and _changelogPopup. Modified OtherConfiguration to handle AutoStatusOrder. Added methods ResetAutoStatusOrder and SaveAutoStatusOrder. Added partial method ModifyShirkPvE in CustomRotation_Actions.cs. Updated RSCommands_Actions.cs for _autoOffWhenDeadPvP check. Refactored RotationConfigWindow to use OtherConfiguration. Updated WelcomeWindow to show changelog popup conditionally. Adjusted StateUpdater to handle AutoStatusOrder as uint. Updated assembly version in WelcomeWindow.cs to 7.1.5.24. Added using directive for RotationSolver.Basic.Configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
RotationSolverproject, focusing on configuration updates, new feature additions, and code improvements. The most important changes include the addition of a new configuration option, the refactoring ofAutoStatusOrderhandling, and updates to the UI and rotation logic.Configuration updates:
_autoOffWhenDeadPvPto handle automatic turn-off during PvP when the player is dead. (RotationSolver.Basic/Configuration/Configs.cs, RotationSolver.Basic/Configuration/Configs.csR62-R65)_changelogPopupto enable a changelog window popup on updates. (RotationSolver.Basic/Configuration/Configs.cs, RotationSolver.Basic/Configuration/Configs.csR79-R82)Refactoring
AutoStatusOrderhandling:AutoStatusOrderfromConfigs.csand added it toOtherConfiguration.csas aHashSet<uint>. (RotationSolver.Basic/Configuration/Configs.cs, [1];RotationSolver.Basic/Configuration/OtherConfiguration.cs, [2]AutoStatusOrderinOtherConfiguration.cs. (RotationSolver.Basic/Configuration/OtherConfiguration.cs, [1] [2] [3]UI updates:
DrawAutoStatusOrderConfigto use the newAutoStatusOrderfromOtherConfigurationand updated the reset functionality. (RotationSolver/UI/RotationConfigWindow.cs, [1] [2] [3] [4]WelcomeWindowto check the newChangelogPopupconfiguration before displaying the changelog. (RotationSolver/UI/WelcomeWindow.cs, [1] [2]Rotation logic updates:
ModifyShirkPvEto set the target type for theShirkaction. (RotationSolver.Basic/Rotations/CustomRotation_Actions.cs, RotationSolver.Basic/Rotations/CustomRotation_Actions.csR33-R37)UpdateRotationStateto handle the new_autoOffWhenDeadPvPconfiguration. (RotationSolver/Commands/RSCommands_Actions.cs, RotationSolver/Commands/RSCommands_Actions.csR190-R195)