Improve performance and readability; add new features #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored multiple classes to replace LINQ methods with loops for better performance. Updated properties and methods in `MNK_Default`, `MonkRotation`, and `Configs` classes for enhanced functionality and configurability. Removed unused `using` directives and simplified conditions in various methods. Added new properties and methods to handle specific game logic and improve code readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
BasicRotations/Melee/MNK_Default.csandRotationSolver.Basic/DataCenter.csfiles, focusing on enhancing functionality and improving code quality. The most important changes are grouped by theme as follows:Functionality Enhancements:
EmergencyAbilitymethod to include logic for handling chakra usage based on theBrotherhoodstatus and chakra levels.AttackAbilitymethod to streamline the use of abilities likeEnlightenmentandHowling Fistbased on theHowlingSingleconfiguration.Configuration Updates:
HowlingSingleproperty tofalseinMNK_Default.cs.CastingStopTimein theConfigs.csfile to control the time before a cast finishes that actions are stopped.Code Quality Improvements:
DataCenter.cs. [1] [2] [3]Array.Empty<T>()andnew List<T>()for better performance and readability inDataCenter.cs. [1] [2]These changes collectively improve the functionality and performance of the codebase while making it easier to maintain and extend in the future.