Adjust cooldowns and streamline Monk action checks #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified `AST_Default` to adjust `DivinationPvE` cooldown check from 45s to 66s for `TheBalancePvE` and `TheSpearPvE`. Simplified `MNK_Default` logic for `TheForbiddenChakraPvE` usage. Updated `MonkRotation` to refine action checks for various abilities based on `Chakra` levels and `Brotherhood` status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
BasicRotationsandRotationSolver.Basicfiles to improve the handling of abilities in different combat states, particularly focusing on theBrotherhoodstatus andChakralevels for the Monk class. The most important changes include adjustments to the general and emergency abilities, as well as modifications to action settings for various Monk abilities.Adjustments to Abilities:
BasicRotations/Healer/AST_Default.cs: Updated the cooldown check forDivinationPvEfrom 45 to 66 seconds in theGeneralAbilitymethod.BasicRotations/Melee/MNK_Default.cs: Simplified the logic in theEmergencyAbilitymethod for handlingTheForbiddenChakraPvEusage based onBrotherhoodstatus.Modifications to Monk Abilities:
RotationSolver.Basic/Rotations/Basic/MonkRotation.cs: Updated theActionChecklogic forSteeledMeditationPvE,SteelPeakPvE,InspiritedMeditationPvE,HowlingFistPvE,ForbiddenMeditationPvE,TheForbiddenChakraPvE,EnlightenedMeditationPvE, andEnlightenmentPvEto account forBrotherhoodstatus and differentChakralevels. [1] [2] [3] [4]