Complete overhaul of Sage, updated Paladin buff logic for lower level support #531
+137
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated SGE_Default to manage Eukrasia actions with new methods (ChoiceEukrasia, DoEukrasia) and streamlined existing logic. Added DisplayStatus method for status information. Enhanced PLD_Beta with new Clemency configurations, adjusted GeneralAbility and AttackAbility methods, and improved HealSingleGCD logic. Updated AoE and single-target logic for Holy Circle and Holy Spirit actions. Modified PaladinRotation to prevent Clemency targeting units with tank stance status. Minor update to SageRotation: removed AddersgallTimerRaw display and streamlined ModifyEukrasianDiagnosisPvE method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant improvements and bug fixes to the
SGE_DefaultandPLD_Betarotations in theBasicRotationsdirectory. The changes focus on refining the logic for Eukrasia actions for Sage and Clemency use for Paladin, as well as adding new configuration options and improving status display.Sage Rotation Improvements:
SetEukrasia,ClearEukrasia, andChoiceEukrasiato better manage Eukrasia actions and their conditions inSGE_Default.cs.DoEukrasiamethod to execute Eukrasia actions based on the current game state.GeneralGCDmethod to incorporate the new Eukrasia logic.DisplayStatusmethod to show the current Eukrasia action and other relevant statuses.Paladin Rotation Enhancements:
PLD_Beta.cs.HealSingleGCDto use Clemency based on the new configuration options.AttackAbilitymethod to include additional actions and improve the logic for using Requiescat and Fight or Flight.GeneralGCDto enhance the use of Holy Spirit and Holy Circle based on Divine Might and Requiescat stacks.Additional Changes:
SGE_Default.cs[1] [2].ModifyClemencyPvEto prevent targeting allies with tank stance.SageRotation.csto remove redundant status display.ModifyEukrasianDiagnosisPvEto remove unnecessary Eukrasia check.