ActionUpdater, MajorUpdater, DrawAbout, and updated resources #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed ActionUpdater.cs to correct StopMovingTime and MovingTime to correctly track player movement Fixed MajorUpdater.cs to replace the foreach loop with a for loop to iterate over DataCenter.VfxDataQueue. This avoids modifying the collection while enumerating it, preventing the InvalidOperationException, maybe. Added Null handling to drawabout countclick section Expanded AnimationLockTime, HostileCastingArea, and HostileCastingKnockback lists Adjusted downtime and out of combat Eurkrasia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve the functionality and performance of the application. The most important changes include updates to the
GeneralGCDmethod logic, modifications to animation lock times, additions to hostile casting areas and knockback lists, and improvements to theDrawAboutmethod.Updates to
GeneralGCDmethod logic:BasicRotations/Healer/SGE_Default.cs: Reordered and added conditions to theGeneralGCDmethod to ensureEukrasiaPvEis used appropriately based on combat status and hostiles in range. [1] [2]Modifications to animation lock times:
Resources/AnimationLockTime.json: Adjusted lock times for specific actions to ensure accurate timing. [1] [2] [3]Resources/AnimationLockTime.json: Added a new entry for action37025.Additions to hostile casting areas and knockback lists:
Resources/HostileCastingArea.json: Added new hostile casting area entries.Resources/HostileCastingKnockback.json: Added new knockback entries to the list.Improvements to
DrawAboutmethod:RotationSolver/UI/RotationConfigWindow.cs: EnsuredcountStris not null before formatting and drawing it, and added a null check forpair.Valuein the loop. [1] [2] [3]Other enhancements:
RotationSolver/Updaters/ActionUpdater.cs: Simplified the logic for updating movement times by directly checkingDataCenter.IsMoving.RotationSolver/Updaters/MajorUpdater.cs: Improved the loop for collecting expired VfxNewData items by using a for loop instead of foreach.