PLD Confiteor low level fix, Autoduty menu update, new pointer for main menu #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified `PLD_Beta.cs` to add level checks for `BladeOfValorPvE`, `BladeOfTruthPvE`, and `BladeOfFaithPvE`, and changed the status check for `ConfiteorPvE` from `Requiescat` to `ConfiteorReady`. - Updated the submodule `ECommons` to a new commit. - Added a new property `HasShownMainMenuMessage` to the `Configs` class in `Configs.cs`. - Added new actions `SharpenedKnife`, `ChocoMeteor`, and `PomCure` to the `BlueMageRotation` class in `BlueMageRotation.cs`. - Added partial methods to modify the settings for `SharpenedKnifePvE`, `ChocoMeteorPvE`, and `PomCurePvE` in `BlueMageRotation.cs`. - In `RotationConfigWindow.cs`, added logic to show a main menu message if it hasn't been shown before and updated the logic for checking incompatible plugins to use a `foreach` loop instead of `Any()`. - Added a private field `_showText` to `RotationConfigWindow.cs` and updated the `DrawHeader` method to conditionally render text based on this field. - Refactored the logic for finding custom rotations and actions in `RotationConfigWindow.cs` to use `foreach` loops instead of LINQ methods. - Updated the logic for displaying statuses in `RotationConfigWindow.cs` to use a `foreach` loop instead of LINQ methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes focused on improving the functionality and readability of the codebase, particularly within the
RotationSolverproject. The most important changes include updates to theGeneralGCDmethod, modifications to theRotationConfigWindowclass, and enhancements to theBlueMageRotationconfiguration.Key Changes:
Functionality Improvements:
BasicRotations/Tank/PLD_Beta.cs: Updated theGeneralGCDmethod to include level checks forBladeOfValorPvE,BladeOfTruthPvE, andBladeOfFaithPvE, and replaced the status check forConfiteorPvEwithConfiteorReady.Configuration Updates:
RotationSolver.Basic/Configuration/Configs.cs: Added a new propertyHasShownMainMenuMessageto track whether the main menu message has been shown.Blue Mage Rotation Enhancements:
RotationSolver.Basic/Rotations/Basic/BlueMageRotation.cs: Added new spellsSharpenedKnife,ChocoMeteor, andPomCureto theBluDPSSpell,BluAOESpell, andBluHealSpellenums, respectively. Implemented partial methods to modify these spells' configurations. [1] [2] [3] [4]UI Enhancements:
RotationSolver/UI/RotationConfigWindow.cs: Multiple updates to improve theDrawErrorZoneandDrawSideBarmethods by replacing LINQ queries with more readableforeachloops. Added conditional rendering for the main menu message and updated the configuration to save the state. [1] [2] [3] [4] [5] [6] [7] [8] [9]Subproject Update:
ECommons: Updated the subproject commit to a new version.