Chaotic heal #563
Merged
Chaotic heal #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified `IsLastGCD` in `SGE_Default.cs` to check with `true` to correct duplicate casts - Added config option in `Configs.cs` for focus-targeted players. - Enhanced `DataCenter.cs` with new duty check properties/methods. - Updated `ObjectHelper.cs` with new using directive, alliance check, focus target method, and fully qualified `ObjectKind`. - Simplified `ModifyPepsisPvE` in `SageRotation.cs`. - Added alliance raid and duty checks in `CustomRotation_OtherInfo.cs`. - Updated `RotationConfigWindow.cs` with new UI text elements for status information.
Introduced a new enum `MasterfulBlitzUse` and a configuration property `MBAbilities` to control Masterful Blitz usage logic. Refactored related logic and updated `TheForbiddenChakraPvE` usage. Renamed `IsAlliance` to `IsAllianceMember` for clarity and updated relevant methods and properties. Corrected property names for consistency and adjusted full party logic to consider 8 or 9 members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
RotationSolver.Basicproject, focusing on improving the logic for handling abilities and statuses, as well as adding new configurations and conditions. The most important changes include updates to theBasicRotationsfor healers and melee classes, adjustments to configuration settings, and enhancements to the data center and helper methods.Updates to Basic Rotations:
BasicRotations/Healer/SGE_Default.cs: Modified theChoiceEukrasiamethod to reset the Eukrasia aim if the last GCD was performed ([BasicRotations/Healer/SGE_Default.csL256-R256](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-048922cde007c3a11c8a1edea2742248b0c16ceb8806c7c8f14c6e2fbd612898L256-R256)).BasicRotations/Melee/MNK_Default.cs: Added theMasterfulBlitzUseenum and related configuration for using abilities as soon as they are available ([[1]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-c8f54622438b0935ab3c9c0d37c4ef394d8a28f6a371bdf821005760f98f7ca3R20-R26),[[2]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-c8f54622438b0935ab3c9c0d37c4ef394d8a28f6a371bdf821005760f98f7ca3R42-R44)). Enhanced theEmergencyAbilityandGeneralGCDmethods to handle ability usage based on the newMasterfulBlitzUsesetting ([[3]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-c8f54622438b0935ab3c9c0d37c4ef394d8a28f6a371bdf821005760f98f7ca3L94-R115),[[4]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-c8f54622438b0935ab3c9c0d37c4ef394d8a28f6a371bdf821005760f98f7ca3L242-R279),[[5]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-c8f54622438b0935ab3c9c0d37c4ef394d8a28f6a371bdf821005760f98f7ca3R296-R298)).Configuration Adjustments:
RotationSolver.Basic/Configuration/Configs.cs: Renamed configuration fieldsisLastAbilityTimerandisFirstAbilityTimertoIsLastAbilityTimerandIsFirstAbilityTimerrespectively ([[1]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-8146c07f057c08a985ecf11930f19a1ce5444efc69fcc45f0edd4e6c341dbe16L385-R390),[[2]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-8146c07f057c08a985ecf11930f19a1ce5444efc69fcc45f0edd4e6c341dbe16R481-R484)).Enhancements to Data Center:
RotationSolver.Basic/DataCenter.cs: Added properties to check if the player is in an alliance raid and other specific duties ([[1]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-2c3e758beb8d040501567ca05ffcedd46534840df24596c1119e971896e8eb42R107-R118),[[2]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-2c3e758beb8d040501567ca05ffcedd46534840df24596c1119e971896e8eb42R127-R128)). Updated lists for party members, alliance members, and other targets to use empty arrays instead of new instances ([[3]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-2c3e758beb8d040501567ca05ffcedd46534840df24596c1119e971896e8eb42L325-R345),[[4]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-2c3e758beb8d040501567ca05ffcedd46534840df24596c1119e971896e8eb42L341-R355)).Helper Method Improvements:
RotationSolver.Basic/Helpers/ObjectHelper.cs: RenamedIsAlliancemethod toIsAllianceMemberand added a check for focus targets being treated as party members ([[1]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-44cc6e98dcd8c3d2aa47210ec76d800058560df9bbff9ce225b3116c47ddc1fcL85-R86),[[2]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-44cc6e98dcd8c3d2aa47210ec76d800058560df9bbff9ce225b3116c47ddc1fcL247-R251),[[3]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-44cc6e98dcd8c3d2aa47210ec76d800058560df9bbff9ce225b3116c47ddc1fcR271-R281),[[4]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-44cc6e98dcd8c3d2aa47210ec76d800058560df9bbff9ce225b3116c47ddc1fcL304-R312),[[5]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-44cc6e98dcd8c3d2aa47210ec76d800058560df9bbff9ce225b3116c47ddc1fcL337-R345)).Other Notable Changes:
RotationSolver.Basic/Rotations/CustomRotation_OtherInfo.cs: Adjusted logic to determine if the party is full and added a description for checking if the player is in an alliance raid ([[1]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-dcfd2506d1ce54221fa2d12787392346547585e896b48e48de6d5fa8be631af4L87-R87),[[2]](https://github.com/FFXIV-CombatReborn/RotationSolverReborn/pull/563/files#diff-dcfd2506d1ce54221fa2d12787392346547585e896b48e48de6d5fa8be631af4R294-R299)).