Refactor and enhance party and alliance member handling #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored methods to improve handling of party and alliance members: - Updated `GetPartyMembers` to iterate over `DataCenter.AllTargets` with additional null checks. - Updated `GetAllianceMembers` to exclude party members. - Refactored raise handling logic with new lists for different categories of dead characters. - Enhanced `GetPriorityDeathTarget` to handle different raise types and prioritize targets accordingly. - Added new helper methods and conditions for better code organization and readability. - Various performance improvements and consistency updates across multiple files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
BasicRotationsandRotationSolver.Basicmodules to enhance functionality and fix bugs. The most important changes include improvements to the Sage rotation logic, updates to theActionBasicInfostruct, and modifications to theDataCenterclass to handle VFX data more safely.Improvements to Sage rotation logic:
BasicRotations/Healer/SGE_Default.cs: Added tracking properties for the last Eukrasia action aim and improved the logic for resetting Eukrasia actions. [1] [2] [3] [4] [5] [6] [7] [8]Enhancements to
ActionBasicInfo:RotationSolver.Basic/Actions/ActionBasicInfo.cs: AddedRangeandEffectRangeproperties to theActionBasicInfostruct.Updates to
DataCenter:RotationSolver.Basic/DataCenter.cs: Modified methods to create a copy of theVfxDataQueueto avoid modification during enumeration. [1] [2]Other notable changes:
RotationSolver.Basic/Helpers/IActionHelper.cs: Updated theIsTheSameTomethod to include anisAdjustparameter for better action comparison.RotationSolver.Basic/Helpers/ObjectHelper.cs: Improved theCanProvokeandIsAttackablemethods for better target validation. [1] [2] [3]