Hotforteachingmode #567
Merged
Hotforteachingmode #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult, fixed teaching mode bugs, and resolved issue with Auto off class switch feautre turning off during area transitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files, primarily focusing on updates to rotation logic for Black Mage and Paladin classes, as well as improvements to the user interface and internal logic for the rotation solver. The most important changes include updates to rotation conditions, addition of new configuration options, and enhancements to the drawing and key handling logic.
Rotation Logic Updates:
BasicRotations/Magical/BLM_Beta.cs: Updated the level requirement for the "Infinite Paradox Rotation" to level 100 and replacedParadoxPvEwithFlareStarPvEin rotation conditions. [1] [2] [3]BasicRotations/Tank/PLD_Default.cs: Added new configuration options for using Clemency with Requiescat and updated the healing logic to prioritizeRequiescatHealBot. [1] [2] [3]Project and File Cleanup:
BasicRotations/RebornRotations.csproj: Removed the old Paladin rotation filePLD_Default_Old.BasicRotations/Tank/PLD_Default_Old: Deleted the outdated Paladin rotation classPLD_Default_Old.UI and Internal Logic Enhancements:
RotationSolver/UI/HighlightTeachingMode/DrawingHighlightHotbar.cs: Enhanced the drawing logic by unifying multiple addon types and simplifying theGetAddonsmethod. [1] [2] [3] [4]RotationSolver/UI/ImGuiHelper.cs: Changed the_lastCheckeddictionary to aSortedListand simplified the key checking logic inExecuteHotKeys. [1] [2]