Error handling, Mudra status check for role actions on NIN, SGE Pepsis restriction, Auto off fix #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `CheckResistance` in `ActionTargetInfo.cs` to handle null `gameObject` and added exception handling with logging. - Modified solo target condition in `ObjectHelper.cs` to `DataCenter.PartyMembers.Count == 1`. - Included `ECommons.DalamudServices` and added exception handling with logging in `StatusHelper.cs`. - Added `Mudra` status check in `NinjaRotation.cs` before using `FeintPvE`. - Required `EukrasianPrognosis` status for `PepsisPvE` in `SageRotation.cs`. - Added `Mudra` status check in `CustomRotation_Ability.cs` before using various abilities. - Added pragma directive in `RSCommands_Actions.cs` to suppress a null check warning and restored the previous job if it changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving error handling, refining status checks, and optimizing conditions for specific abilities in the
RotationSolver.Basicproject. The most important changes include adding exception handling to methods, refining status checks for abilities, and updating conditions for attackable targets.Error Handling Improvements:
RotationSolver.Basic/Actions/ActionTargetInfo.cs: Added null checks and exception handling to theCheckResistancemethod to ensure robustness. [1] [2]RotationSolver.Basic/Helpers/StatusHelper.cs: Added null checks and exception handling in theGetAllStatusmethod to handle cases whereStatusListis null.Status Checks for Abilities:
RotationSolver.Basic/Rotations/Basic/NinjaRotation.cs: Updated theDefenseAreaAbilitymethod to include a status check forStatusID.Mudrabefore usingFeintPvE.RotationSolver.Basic/Rotations/CustomRotation_Ability.cs: Added status checks forStatusID.Mudrain multiple methods to ensure abilities are used appropriately. [1] [2] [3] [4] [5] [6]Conditions for Attackable Targets:
RotationSolver.Basic/Helpers/ObjectHelper.cs: Refined conditions in theIsAttackablemethod to better handle scenarios with solo targets.Miscellaneous:
RotationSolver.Basic/Helpers/StatusHelper.cs: Added a missing using directive forECommons.DalamudServices.RotationSolver/Commands/RSCommands_Actions.cs: Disabled a compiler warning related to a nullable value type check.These changes collectively enhance the robustness and functionality of the
RotationSolver.Basicproject.