Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMN Crimson Cyclone fix for not respecting movement settings, and attempted combo fix for StalwartSoul #57

Merged
merged 3 commits into from
Apr 3, 2024
Merged

SMN Crimson Cyclone fix for not respecting movement settings, and attempted combo fix for StalwartSoul #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6ff50f
Fix actiontype on crimson cyclone
LTS-FFXIV Apr 3, 2024
39523c6
woops its a gcd
LTS-FFXIV Apr 3, 2024
aef23a4
also sneaking in a combo fix for StalwartSoul not being associated wi…
LTS-FFXIV Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RotationSolver.Basic/Rotations/Basic/DarkKnightRotation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ static partial void ModifyQuietusPvE(ref ActionSetting setting)

static partial void ModifyStalwartSoulPvE(ref ActionSetting setting)
{
setting.StatusNeed = [StatusID.SaltedEarth];
setting.ComboIds = [ActionID.UnleashPvE];
setting.CreateConfig = () => new()
{
AoeCount = 2,
Expand Down
11 changes: 10 additions & 1 deletion RotationSolver.Basic/Rotations/Basic/SummonerRotation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ static partial void ModifyRekindlePvE(ref ActionSetting setting)
static partial void ModifyCrimsonCyclonePvE(ref ActionSetting setting)
{
setting.StatusNeed = [StatusID.IfritsFavor];
setting.SpecialType = SpecialActionType.MovingForward;
}

static partial void ModifyMountainBusterPvE(ref ActionSetting setting)
Expand Down Expand Up @@ -261,4 +262,12 @@ protected override bool DefenseAreaAbility(out IAction? act)
if (AddlePvE.CanUse(out act)) return true;
return base.DefenseAreaAbility(out act);
}
}

/// <inheritdoc/>
[RotationDesc(ActionID.CrimsonCyclonePvE)]
protected override bool MoveForwardGCD(out IAction? act)
{
if (CrimsonCyclonePvE.CanUse(out act)) return true;
return base.MoveForwardGCD(out act);
}
}