Refactor and enhance rotation logic and configurations #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored SCH, SGE, and WHM rotation logic for better readability and maintainability. Updated `SCH_Default.cs` and `SGE_Default.cs` to iterate over party members and tanks for specific actions. Simplified and refactored methods in `SGE_Default.cs` to remove LINQ. Updated `ECommons` subproject commit. Removed `IsLastAbilityUsable` and `IsFirstAbilityUsable` checks in `BaseAction.cs`. Added new configuration options in `Configs.cs` for raising players and adjusted `_action4head` value. Updated `DataCenter.cs` with XML documentation comments and adjusted `CalculatedActionAhead`. Refactored `StatusHelper` and `TargetFilter` methods to use explicit loops instead of LINQ. Improved `CustomRotation` logic with additional checks and conditions. Commented out `UseLimitBreak` method in `CustomRotation_GCD.cs`. Added null checks and early returns in `CustomRotation` methods. Cleaned up debug text in `RotationConfigWindow`. Simplified `RemoveExpiredVfxData` method in `MajorUpdater`. Enhanced `TargetUpdater` with explicit loops, new configuration checks, and improved logic for determining valid raise targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve the healing logic and configuration options in the
BasicRotationsproject, particularly for the healer classes. The most important changes include adding new actions to the rotation descriptions, refining the healing logic, and updating configuration options.Improvements to healing logic:
BasicRotations/Healer/SCH_Default.cs: AddedManifestationPvEto theHealSingleGCDrotation description andConcitationPvEandAccessionPvEto theDefenseAreaGCDrotation description. [1] [2]BasicRotations/Healer/SGE_Default.cs: Refined the loop logic inHealSingleAbilityto check each party member and tank individually for health thresholds before using specific healing actions.BasicRotations/Healer/SGE_Default.cs: Simplified theChoiceEukrasiamethod by usingelse ifstatements and removed redundant code.Configuration updates:
RotationSolver.Basic/Configuration/Configs.cs: Added new experimental configuration options for raising non-healers, prioritizing Red Mage and Summoners, and setting a buffer for using swiftcast before the next GCD.RotationSolver.Basic/Configuration/Configs.cs: Adjusted theAction Aheadtimer to 0.3 seconds to improve the queuing of the next GCD.Codebase simplification:
BasicRotations/Healer/SGE_Default.cs: Removed theNewELogicconfiguration option and associated logic.RotationSolver.Basic/Actions/BaseAction.cs: Removed theIsLastAbilityUsableandIsFirstAbilityUsablemethods and their v2 counterparts, simplifying theCanUsemethod.Minor fixes:
BasicRotations/Healer/WHM_Default.cs: Updated healing logic to check ifSwiftcastPvEwas the last action performed, improving the handling of swiftcast logic. [1] [2] [3]ECommons: Updated the submodule to a new commit.