Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configs, refactor, and enhance documentation #579

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

LTS-FFXIV
Copy link
Member

This pull request introduces several changes to the RotationSolver project, focusing on adding new configurations, improving the handling of certain targets, and enhancing the documentation for various classes and methods. The most significant changes include adding new configuration options, updating helper methods to account for new conditions, and adding detailed documentation comments to various classes and methods.

New Configuration Options:

  • Added new configuration options to ignore specific immune targets in different scenarios, such as Ark Angels in Jeuno, targets in Cloud of Darkness Chaotic, and Strong of Shield targets in The Tower at Paradigm's Breach (RotationSolver.Basic/Configuration/Configs.cs).

Helper Method Enhancements:

  • Updated IsAttackable method to include checks for the new configuration options (RotationSolver.Basic/Helpers/ObjectHelper.cs).
  • Added new methods IsCODBossImmune and IsHanselorGretelSheilded to check for specific immunities (RotationSolver.Basic/Helpers/ObjectHelper.cs).

Status Tracking System:

  • Improved source gen system to allow for tracking of unnamed statuses

Documentation Improvements:

  • Added comprehensive documentation comments to various classes and methods across multiple files to improve code readability and maintainability. This includes classes such as ActionCategoryGetter, ActionGetterBase, ActionIdGetter, ActionRotationGetterBase, ContentTypeGetter, ExcelRowGetter, and ItemGetter. [1] [2] [3] [4] [5] [6] [7]

Added new configuration options to ignore specific immune targets in various scenarios. Updated multiple files to include XML documentation comments for better code readability and maintenance. Refactored methods and data structures for improved performance and readability. Enhanced error handling and code generation logic in source generators.
@LTS-FFXIV LTS-FFXIV merged commit 89aa664 into main Jan 17, 2025
@LTS-FFXIV LTS-FFXIV deleted the CODandRedtext branch January 19, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant