Update various classes with new properties and logic #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
LTS-FFXIV
commented
Jan 20, 2025
LTS-FFXIV
commented
- SMN_Default.cs: Add CrimsonCycloneDistance property (1-20 yalms), update AddCrimsonCyclone description, and adjust CrimsonCyclone logic.
- PLD_Default.cs: Add status checks for AtonementPvE, refine conditions for SepulchrePvE, SupplicationPvE, and RoyalAuthorityPvE.
- IActionHelper.cs: Add methods to check last combo action and if the last action was a combo action.
- PaladinRotation.cs: Minor formatting change for #region Status Tracking comment.
- CustomRotation_OtherInfo.cs: Add AllTargets property, and methods to check last combo action with warnings.
- SMN_Default.cs: Add CrimsonCycloneDistance property (1-20 yalms), update AddCrimsonCyclone description, and adjust CrimsonCyclone logic. - PLD_Default.cs: Add status checks for AtonementPvE, refine conditions for SepulchrePvE, SupplicationPvE, and RoyalAuthorityPvE. - IActionHelper.cs: Add methods to check last combo action and if the last action was a combo action. - PaladinRotation.cs: Minor formatting change for #region Status Tracking comment. - CustomRotation_OtherInfo.cs: Add AllTargets property, and methods to check last combo action with warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.