Enhance ability logic and update dependencies #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `AST_Default` with `StellarNow` property and new condition in `EmergencyAbility` method. Modified `SGE_Default` to change conditions for Prognosis and Diagnosis abilities. Enhanced `NIN_Default` with improved decision-making logic for Ninjutsu and other abilities, including new methods and regions for movement and oGCD logic. Added `DumbQueen` config to `MCH_Default` and updated logic for Automation Queen usage. Added `InterventionTank` config to `PLD_Default` and updated logic for Intervention on CoTank. Changed visibility of status arrays in `StatusHelper` and added XML documentation. Updated `System.Drawing.Common` to `9.0.1` and `Microsoft.CodeAnalysis.CSharp` to `4.12.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes across multiple files to improve the functionality and maintainability of the rotation logic for different classes. The key changes are grouped by theme and listed below.
New Features and Enhancements:
BasicRotations/Healer/AST_Default.cs: Added a new configuration optionStellarNowto detonate Earthly Star when the player has Giant Dominance. [1] [2]BasicRotations/Ranged/MCH_Default.cs: Introduced a new configuration optionDumbQueento use Automation Queen as soon as it's available. [1] [2]BasicRotations/Tank/PLD_Default.cs: Added a new configuration optionInterventionTankto use Intervention on the CoTank during tankbusters. [1] [2]Bug Fixes:
BasicRotations/Healer/SGE_Default.cs: Fixed the logic for usingPrognosisPvEandDiagnosisPvEby checking if_EukrasiaActionAimisnull. [1] [2] [3]Codebase Maintenance:
RotationSolver.Basic/Helpers/StatusHelper.cs: Changed several internal status arrays to public and added empty XML documentation comments. [1] [2]Dependency Updates:
RotationSolver.Basic/RotationSolver.Basic.csproj: UpdatedSystem.Drawing.Commonpackage to version 9.0.1.RotationSolver.SourceGenerators/RotationSolver.SourceGenerators.csproj: UpdatedMicrosoft.CodeAnalysis.CSharppackage to version 4.12.0.