Refactor Ninjutsu logic and improve burst phase handling #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `_rabbitMediumFailures` and its logic. Added conditions for `MeisuiPvE` and `TenChiJinPvE` usage. Modified `SetNinjutsu` to avoid redundant actions. Updated `ChoiceNinjutsu` for `TenPvE` during `InTrickAttack`. Enhanced burst phase handling for `Kassatsu` across multiple `Do*` methods. Added null checks for `_ninActionAim` in various `Do*` methods. Improved `DoFumaShuriken` for multi-stage Ninjutsu actions. Added fallback to `GeneralGCD` if `IsExecutingMudra`. Removed `Mudra Failure Count` display in `DisplayStatus`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
_rabbitMediumFailuresand its logic. Added conditions forMeisuiPvEandTenChiJinPvEusage. ModifiedSetNinjutsuto avoid redundant actions. UpdatedChoiceNinjutsuforTenPvEduringInTrickAttack. Enhanced burst phase handling forKassatsuacross multipleDo*methods. Added null checks for_ninActionAimin variousDo*methods. ImprovedDoFumaShurikenfor multi-stage Ninjutsu actions. Added fallback toGeneralGCDifIsExecutingMudra. RemovedMudra Failure Countdisplay inDisplayStatus.