Refactor RotationConfigWindow and update submodule #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated subproject commit to c28878a. Refactored DrawErrorZone in RotationConfigWindow: - Check for incompatible plugin using FirstOrDefault. - Removed hasIncompatiblePlugin boolean check. - Simplified message string construction. - Refactored ImRaii.PushColor with using var syntax. - Improved readability by removing unnecessary braces.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
ECommonssubmodule and improvements to theDrawDutyRotationmethod inRotationSolver/UI/RotationConfigWindow.cs. The most important changes include updating the submodule commit reference and refining the logic for handling incompatible plugins.Updates and improvements:
ECommons: Updated the submodule commit reference to a new commit.RotationSolver/UI/RotationConfigWindow.cs: Refined the logic inDrawDutyRotationto check for a specific type of installed incompatible plugin and streamlined the message display.