Correct Alliance member raising logic #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialization of `deathAllianceHealers` and `deathAllianceSupports` now includes the contents of `deathParty`, ensuring these lists start with the same elements as `deathParty`. Added a new private static method `GetPriorityDeathTarget` to determine the highest priority target for raising from a list of valid targets, potentially improving the logic for handling death targets in the game.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
RotationSolver/Updaters/TargetUpdater.csfile to improve the handling of hostile targets and death targets in theGetAllHostileTargetsmethod. The most important changes include initializingdeathAllianceHealersanddeathAllianceSupportswithdeathPartyand adding a new line for code readability.Improvements to hostile targets handling:
RotationSolver/Updaters/TargetUpdater.cs: InitializeddeathAllianceHealersanddeathAllianceSupportswithdeathPartyto ensure they are populated correctly.Code readability improvements:
RotationSolver/Updaters/TargetUpdater.cs: Added a new line for better separation of methods.The initialization ofdeathAllianceHealersanddeathAllianceSupportsnow includes the contents ofdeathParty, ensuring these lists start with the same elements asdeathParty.Added a new private static method
GetPriorityDeathTargetto determine the highest priority target for raising from a list of valid targets, potentially improving the logic for handling death targets in the game.