-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: include Python 3.10 #23
Conversation
.github/workflows/test.yml
Outdated
@@ -37,6 +37,11 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v2 | |||
|
|||
- uses: actions/setup-python@v2 | |||
with: | |||
python-version "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to do, no?
python-version "3.10" | |
python-version: ${{ matrix.py }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nox action is exactly the same as activating all installed versions of Python. Except it's not picking up 3.10 for some reason - maybe it's pinned to an old list somehow. This fixes is by adding the missing version.
Using setup-python with matrix.py
+ pipx run nox
would be another way to go, no setup-nox required. Can change if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is very simple (https://github.com/excitedleigh/setup-nox/blob/main/src/setup-python.ts), so I don't really see why 3.10 isn't being picked up; I assumed it would be due to looking at that code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move to something like this then.
https://github.com/FFY00/dbus-objects/blob/main/.github/workflows/tests.yml
fa4eab8
to
b0497d7
Compare
No description provided.