Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example.com from the list? #359

Closed
noinkling opened this issue May 19, 2022 · 1 comment · Fixed by #360
Closed

Remove example.com from the list? #359

noinkling opened this issue May 19, 2022 · 1 comment · Fixed by #360

Comments

@noinkling
Copy link
Contributor

example.com is an IANA reserved domain, rather than a temporary/throwaway email domain. It's often used in tests.

The purpose of this library is not to stop a user from making up a non-working email address (which is impossible with a blacklist approach - that's what email verification is for), so for the same reason I don't think the list should include reserved domains. The other reserved domains example.net and example.org (and various TLDs) aren't included, so at the very least it's inconsistent.

Can we remove example.com?

@noinkling
Copy link
Contributor Author

After some digging it was initially added in #17 / c5d0d04

In the repo for that source it was later regarded a mistake and removed: disposable-email-domains/disposable-email-domains#147

noinkling added a commit to noinkling/mailchecker that referenced this issue May 19, 2022
noinkling added a commit to noinkling/mailchecker that referenced this issue Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant