Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP class: convert isBlacklisted method in public #131

Closed
wants to merge 6 commits into from

Conversation

apachejack
Copy link

Hi again,

Sorry, I think I edited the incorrect file in my last PR. Looks more logical editing the template file (.tmpl.php) instead of the compiled one with the blacklisted emails.
I downloaded the latest version of the library and I didn't see my changes in the class.

Thanks again.

I copy again the reasons for changing this code:

I would like to convert one of the methods in public to be able to use the black-list without validating the email using the PHP filter function.

filter_var($email, FILTER_VALIDATE_EMAIL) doesn't validate correctly the allowed email patterns exposed in this Wikipedia article: https://en.wikipedia.org/wiki/Email_address#Local-part

Thanks for this great job,
Kind regards.

@FGRibreau
Copy link
Owner

@apachejack could you please rebase?

@FGRibreau FGRibreau closed this in 4b138cc Mar 11, 2018
@FGRibreau
Copy link
Owner

Released in v3.1.0

@apachejack
Copy link
Author

Hi @FGRibreau

Why is this change not reflected in the file MailChecker.php despite the template file was modified https://github.com/FGRibreau/mailchecker/blob/master/platform/php/MailChecker.php?

Am I doing something wrong? :(

Thanks again,
Kind regards.

@FGRibreau
Copy link
Owner

There was an issue on the release script, it's fixed thus available in v3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants