Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite a bit the PHP implementation #184

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Rewrite a bit the PHP implementation #184

merged 1 commit into from
Jun 3, 2019

Conversation

lyrixx
Copy link
Collaborator

@lyrixx lyrixx commented May 22, 2019

The PHP before this patch is a bit old. Now it use some "better style"

Note: this is still not perfect, but much better

@FGRibreau
Copy link
Owner

That's good for me, however you might want to change this line as well right?

@lyrixx lyrixx force-pushed the php-the-good-way branch from 5822e41 to 4dfd7ae Compare June 3, 2019 08:59
@lyrixx
Copy link
Collaborator Author

lyrixx commented Jun 3, 2019

Done. Thanks

@FGRibreau FGRibreau merged commit 258b1b3 into FGRibreau:master Jun 3, 2019
@FGRibreau
Copy link
Owner

released in v3.2.31 👍

@lyrixx lyrixx deleted the php-the-good-way branch June 4, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyrixx @FGRibreau