Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): regression in input check since 1.6.2 #58

Merged
merged 1 commit into from
Mar 20, 2016

Conversation

gierschv
Copy link
Contributor

Mailchecker.is_valid(undefined) should return false, not crash (since f5f5b36);

By the way, thanks for the breaking change in f5f5b36 released in patch release 1.6.2 (MailChecker.is_valid vs MailChecker).

Cheers,
Vincent

FGRibreau added a commit that referenced this pull request Mar 20, 2016
fix(node): regression in input check since 1.6.2
@FGRibreau FGRibreau merged commit 2af00be into FGRibreau:master Mar 20, 2016
@FGRibreau
Copy link
Owner

+1, note that 1.6.2 was unpublished soon after its release:

   [ '0.1.0',
     '0.1.1',
     '0.1.2',
     '0.1.3',
     '0.1.4',
     '0.1.5',
     '0.1.7',
     '0.1.8',
     '0.1.10',
     '0.1.11',
     '0.2.0',
     '1.0.0',
     '1.1.0',
     '1.1.1',
     '1.2.0',
     '1.3.0',
     '1.3.1',
     '1.4.0',
     '1.5.0',
     '1.5.1',
     '1.5.2',
     '1.6.0',
     '1.6.1',
     '2.0.0',
     '2.0.1' ],

@FGRibreau
Copy link
Owner

@gierschv mailchecker v3.0.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants