Added functions to print a message and symbol after stopping #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGRibreau
reviewed
Jun 17, 2022
Cargo.toml
Outdated
| @@ -17,3 +17,4 @@ include = ["src/**/*", "README.md"] | |||
| lazy_static = { version = "1.4.0" } | |||
| maplit = { version = "1.0.2" } | |||
| strum = { version = "0.24.0", features = ["derive"] } | |||
| terminal-log-symbols = "0.1.6" | |||
There was a problem hiding this comment.
I would prefer not to add another dependency, could we just keep your changes on stop_and_persist and stop_with_message? Thanks :)
There was a problem hiding this comment.
Ok, I will revert the commits
|
Thanks a lot @AnishDe12020! Released in v4.1.0 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
I have added a
stop_and_persistfunction that stops the spinner and then shows a symbol and a message. I have also addedsucceed,fail,warn,info, andunknownfunctions that use thestop_and_persistfunction with a pre-defined symbol (with color and, theoretically, support for windows terminals).Note: I might also push out some more features in this pr if it is going to take time (so that there arent many prs from me that sit unmerged). Do let me know if I should use any other approach