Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CV Form to HeadRef and FTA #929

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheCommandCat
Copy link
Contributor

@TheCommandCat TheCommandCat commented Jan 10, 2025

Description

Hey,
This PR adds tabs to headref and the FTA roles, including a new tab for managing CV Forms alongside the main functionality.

Closes #925.

Type of Change

Please select the option(s) that best describe this change:

  • New feature (non-breaking change that adds functionality)

Questions for Further Implementation

  1. I'm not sure if tab navigation is actually best approach here(made it for now because it was in all the other CV Form roles)
    Would it make more sense to move CV Forms to a small button (similar to the Reports button)? Which navigation approach would you prefer?

  2. When creating a CV Form, the page does not reload, so the created form is not shown

    • Should this behavior be considered a bug and addressed in a separate issue?
    • If we address it here, what approach would you prefer for fixing this? I thought maybe redirect back to the main role functionality page or reload the page with a timeout to show the new form

Screenshots


@johnmeshulam
Copy link
Member

Issue #928 is a non-issue and everything behaves as expected. Please do not modify CV form behavior as part of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Enable CV Form for headref and FTA
2 participants