-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created event for ScheduledTimeChanged and added snackbars based on that #897
base: main
Are you sure you want to change the base?
Created event for ScheduledTimeChanged and added snackbars based on that #897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, added some comments regarding standardization and usability,
… and matchParticipant
…eduleUpdateSnackbars
Should the judge-advisor also receive an informational message instead of just 'הלוז עודכן'? If so, what format should the message be? @johnmeshulam |
Please see my previous comments. As I mentioned, the schedules time does not change |
Im really sorry about all the mess... I'm not entirely sure I understood your last comment. As I understand it, the schedule itself remains unchanged, and only the assigned teams are updated. Based on your advice, I renamed the events to more appropriate names. Is the issue with the specific message 'הלוז עודכן'? Should I update it to something like 'הקבוצה בסשן השיפוט בשעה {time} עודכנה' instead? If yes, should i pass the updated |
The logic will not work as it's written right now. It seems like you understood eerything correctly but the logic itself is flawed, if I'll have time l'll leave more detailed comments later |
Hey, I just pushed a small fix for a mistake I made (apologies for that). However, there are still two things that could be improved:
|
Closes #849
Hey, Apologies for the new PR - I accidentally deleted the branch while trying to upload the updated code, which caused the first PR to close.
Based on the feedback from @johnmeshulam, I've added a new event specific to schedule changes and included snackbars for the Field Manager and Judge Advisor when the event is emitted.
While working on this, I started wondering if it might be useful to include more context about the specific changes in the schedule (e.g., by passing data through the event and displaying it in the snackbars). Do you think this level of detail would be helpful for these roles, or is the current approach good enough?