Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error in viewflif gracefully #413

Merged
merged 3 commits into from
May 10, 2017
Merged

Conversation

hrj
Copy link
Member

@hrj hrj commented May 5, 2017

This was originally created to address #412
In my system before the fix, viewflif goes into an infinite loop (because d doesn't become NULL). There is no seg fault. After these changes, viewflif closes gracefully.

I thought the seg fault seen by @matthiaskrgr would go away too, but probably that's a different issue (see comments below).

@matthiaskrgr
Copy link
Member

I can still reproduce with this changeset, still crashing. :/

@hrj
Copy link
Member Author

hrj commented May 7, 2017

@matthiaskrgr Does it crash always or sometimes?

There is a small chance that there is a race condition. But if it is crashing always then there is some other problem, because it is not crashing even once for me, with this change.

Just to be sure, can you do a make clean and then a make viewflif?

@matthiaskrgr
Copy link
Member

I freshly cloned the UprootStaging repo and checked out the branch for testing so there is no need for a clean build.

Hmm, it looks like there is a very high probability of crashing on my sys. With the crash command, it only did NOT crash one in 30 times.

@hrj
Copy link
Member Author

hrj commented May 7, 2017

@matthiaskrgr Hmm, there is probably some other problem which is compounding with the issue that this PR fixes.

I will remove the closes #412 comment so that the issue remains open, but this PR can be merged.

@matthiaskrgr
Copy link
Member

Ok

@jonsneyers jonsneyers merged commit fceb7ff into FLIF-hub:master May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants