Run jshint and clean up issues

[TimRudy]

There are code changes in 2 files:

• app\scripts\services\drivers.js - moved functions inside ng scope
• app\scripts\graphics\joint.routers.js - changed != null to !== null

[cavearr]

Wooo what a rhythm! we go like a rocket!

[cavearr]

@TimRudy tell me when you do for finish this first start point and i'll start the automatic prettier in actions.

Good work!!

[TimRudy]

OK, yes, the prettier caused a couple of changes to translation keys, e.g. "<b>WARNING!</b><br>\n" " The changes made here will also be applied to all the\n" So this weekend I should be able to submit a PR that makes this all official, with all the .po files synched up. Thanks. Do you want to try 'npm i' and package-lock.json to see if the workflow job proceeds further without error? - Have a good weekend

…

On Sat, Feb 1, 2025 at 2:10 PM Carlos Venegas Arrabé < ***@***.***> wrote: @TimRudy <https://github.com/TimRudy> tell me when you do for finish this first start point and i'll start the automatic prettier in actions. Good work!! — Reply to this email directly, view it on GitHub <#867 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6CTIR5IHN7QATCCKOXDXT2NUL2HAVCNFSM6AAAAABWI6LZLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGA3TIOBTGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cavearr]

@TimRudy, take your time! There is no rush. I'm only telling you this because I don't want to activate the bot until you've finished the first full batch. I'll check the package-lock.json, don't worry 👍
As I said, don't get overwhelmed with this and at your own pace.

[TimRudy]

Hi Charli, Some items this morning... 1. I suppose we should change these to @v4 in all the .yml files: ***@***.*** ***@***.*** 2. Would you like to give me Spanish for these? "Are you sure you want to clear the recent projects list?" "Clear Recent Projects" "Clear Recently Opened" "Don’t Save" "Error enabling driver type {{type}}" <- (type==ftdi or serial) "Error reading the file: {{error}}" "Import code" <- Should we say Import source code? Import Verilog code? or <- Import source? Import from source code file? ... whatever? "Open Recent" "Recent projects cleared" "Screen recording error. Review your permissions." "Snapshot saved: {{name}}" "Video saved: {{name}}" "Take PNG" "Take Video" "Ukrainian" "Wait for <b></b> seconds" "Design contains tri-state I/O. You need to update your Preferences:<br />&nbsp;&nbsp;&nbsp;<b>Advanced features → Allow tri-state connections</b>,<br />and reimport the block." -> My attempt for this one: "El diseño contiene E/S de tri-estados. Debe actualizar sus Preferencias: Características avanzadas → Permitir conexiones tri-estado, y volver a importar el bloque." <- I hope that is Spanish and was not translated to Eng by my browser! 3. I wanted to CC @lmcapacho <https://github.com/lmcapacho> but I don't have his e-mail. When I try to debug Icestudio I no longer get "F12" or "Inspect" in NW so I can't check the DOM. Did I forget something basic like a DEVELOP flag? Thanks for everything

…

On Sat, Feb 1, 2025 at 2:58 PM Carlos Venegas Arrabé < ***@***.***> wrote: @TimRudy <https://github.com/TimRudy>, take your time! There is no rush. I'm only telling you this because I don't want to activate the bot until you've finished the first full batch. I'll check the package-lock.json, don't worry 👍 As I said, don't get overwhelmed with this and at your own pace. — Reply to this email directly, view it on GitHub <#867 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6CTIQETZN65NIXFA5DEDL2NURPFAVCNFSM6AAAAABWI6LZLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGA4TANBTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cavearr]

Hi @TimRudy ! i don't have @lmcapacho mail, @lmcapacho if you want write tim and me an email (in fpgawars list are our mails ) to meet in contact!

In the afternoon i'll reply you, the sdk is disabled in the package, i'll build the next wip with the suppor of sdk, sorry Tim! but if you start from source, change in package.json the nwjs package from 0.95.0 to "nw": "0.95.0-sdk" and reinstall it. And upgrade your nodejs to 23.3.0 (i updated nwjs this weekend) with that you have F12 again if you launch from source

[cavearr]

Hi @TimRudy ! here you are!:

1. I suppose we should change these to @v4 in all the .yml files

This is on my side, when you finish the first "manual check" i activate the bot account and start to prettify automatically, tell me when you do for finished the manual check.

2. Would you like to give me Spanish for these?

"Are you sure you want to clear the recent projects list?"
¿Desea vaciar el listado de proyectos recientes?

"Clear Recent Projects"
Vaciar listado de proyectos recientes

"Clear Recently Opened"
Vaciar ficheros abiertos recientemente.

"Don’t Save"
No guardes

"Error enabling driver type {{type}}" <- (type==ftdi or serial)
Error habilitando driver clase {{type}}

"Error reading the file: {{error}}"
Error abriendo el fichero: {{error}}

"Import code" <- Should we say Import source....
Importar código. <- I like your suggestion and i like "import source code", in near future we could import other languages

"Open Recent"
Abierto recientemente

"Recent projects cleared"
Proyectos recientes vaciado.

"Screen recording error. Review your permissions."
Error al grabar, puede ser un error de permisos, revisa la configuración.

"Snapshot saved: {{name}}"
Imagen guardada:{{name}}

"Video saved: {{name}}"
Vídeo guardado: {{name}}

"Take PNG"
Guardar PNG

"Take Video"
Grabar Vídeo

"Ukrainian"
Ukraniano

"Wait for seconds"
Esperar durante segundos"

"Design contains tri-state I/O. You need to update your Preferences:
   Advanced features → Allow tri-state
connections,
and reimport the block."

El diseño contiene E/S tri-estado. Debe actualizar su configuración, para ello puede hacerlo en:
Preferencias Características avanzadas → Permitir conexiones tri-estado, y volver a
importar el bloque."

Thanks for all @TimRudy ! 🚀