-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix freva and freva-dev broken images, fix docs and tests CI issues, fix minor typo in API ref #212
Conversation
…e privilege and reverting the init maria db lines
looks ready to be reviewed ... |
PR still needs a couple of commits to fix the issue of tests to be ready for review |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
4666193 | Triggered | Generic Password | 3cd0337 | docker-compose.yaml | View secret |
4666193 | Triggered | Generic Password | d5bcbb0 | docker-compose.yaml | View secret |
4666193 | Triggered | Generic Password | b36d1aa | docker-compose.yaml | View secret |
4666193 | Triggered | Generic Password | 39b445e | docker-compose.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@antarcticrainforest it's ready to review, but i think let's don't change the version, to be able to superimpose the current changes to the version Another question, do we need to skip guardian job as Thanks in advance |
i got an offline LGTM form @antarcticrainforest |
The latest changes to the Dockerfile successfully built the images, but when running the
freva-dev
andfreva
images, mariadb failed to start, causing the related pipelines infreva-dev
in gitlab to break. To resolve this, some adjustments has been made to thedocker-entrypoint.sh
script in this PR to create images based on the the latest version of mariadb.CI of tests is red, but i think it has to be re-run in working hours ... tomorrow morning i re-run
Closes #209