Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix freva and freva-dev broken images, fix docs and tests CI issues, fix minor typo in API ref #212

Merged
merged 13 commits into from
Sep 17, 2024

Conversation

mo-dkrz
Copy link
Contributor

@mo-dkrz mo-dkrz commented Sep 15, 2024

The latest changes to the Dockerfile successfully built the images, but when running the freva-dev and freva images, mariadb failed to start, causing the related pipelines in freva-dev in gitlab to break. To resolve this, some adjustments has been made to the docker-entrypoint.sh script in this PR to create images based on the the latest version of mariadb.

CI of tests is red, but i think it has to be re-run in working hours ... tomorrow morning i re-run

Closes #209

…e privilege and reverting the init maria db lines
@mo-dkrz
Copy link
Contributor Author

mo-dkrz commented Sep 16, 2024

looks ready to be reviewed ...

@mo-dkrz
Copy link
Contributor Author

mo-dkrz commented Sep 16, 2024

PR still needs a couple of commits to fix the issue of tests to be ready for review

Copy link

gitguardian bot commented Sep 16, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4666193 Triggered Generic Password 3cd0337 docker-compose.yaml View secret
4666193 Triggered Generic Password d5bcbb0 docker-compose.yaml View secret
4666193 Triggered Generic Password b36d1aa docker-compose.yaml View secret
4666193 Triggered Generic Password 39b445e docker-compose.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mo-dkrz mo-dkrz changed the title fix docker-entrypoint.sh to ensure creating healthy images based on the latest mariadb image fix freva and freva-dev broken images, fix docs and tests CI issues, fix minor typo in API ref Sep 16, 2024
@mo-dkrz
Copy link
Contributor Author

mo-dkrz commented Sep 16, 2024

@antarcticrainforest it's ready to review, but i think let's don't change the version, to be able to superimpose the current changes to the version 2408.0.0. Or, cause all created images which are listed in https://github.com/orgs/FREVA-CLINT/packages?repo_name=freva are broken, let's remove them or and add new version 2409.0.0

Another question, do we need to skip guardian job as test-cred?

Thanks in advance

@mo-dkrz
Copy link
Contributor Author

mo-dkrz commented Sep 17, 2024

i got an offline LGTM form @antarcticrainforest

@mo-dkrz mo-dkrz merged commit 5960929 into main Sep 17, 2024
19 checks passed
@mo-dkrz mo-dkrz deleted the fix-images branch September 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solr connection issue on freva docker image
1 participant