[3.0] kill bgp_attr_refcount() #1116
Conversation
This attempt at optimization has cost us more than a week's worth of time on several people hunting down the subtle bug that it was missing an increment on attr->lcommunity. This is absolutely not worth the maintenance cost. Signed-off-by: David Lamparter <[email protected]>
|
To track here the conversation in slack: bgp_attr_deep_dup and bgp_attr_deep_free are both missing the lcommunity portion as well. I believe @eqvinox will issue an expanded PR to cover these issues as well. |
bgp_attr_deep_dup() needs to be removed just like bgp_attr_refcount(), but that's a little too intrusive for the 3.0 branch at this point. Signed-off-by: David Lamparter <[email protected]>
|
Once CI passes I will push. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-1622/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base138 Static Analyzer issues remaining.See details at |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-1623/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base138 Static Analyzer issues remaining.See details at |
This attempt at optimization has cost us more than a week's worth of
time on several people hunting down the subtle bug that it was missing
an increment on attr->lcommunity.
This is absolutely not worth the maintenance cost.
Signed-off-by: David Lamparter [email protected]