Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: Extend the FPM module to push the missing SRv6 information #12301

Closed

Conversation

cscarpitta
Copy link
Contributor

SRv6 is supported in SONiC (sonic-net/sonic-swss#1964) as part of release 202211 (~Nov 2021). Zebra’s dplane_fpm_nl module allows SONiC to learn the forwarding information computed by the FRR routing suite. Currently, the information exported by dplane_fpm_nl does not include some SRv6 fields required by SONiC.

We already have two open PRs to support two functionalities required for the integration of FRR and SONiC: #12219 adds the support for SRv6 uSID behaviors to FRR; #12261 adds the missing source address parameter for the SRv6 encapsulation.

This PR completes the integration work of FRR and SONiC by extending the dplane_fpm_nl module to push the missing SRv6 information to SONiC.

Signed-off-by: Carmine Scarpitta [email protected]

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Nov 10, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8301/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8301/artifact/TP3U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 6
  • Debian 10 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 6
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 1
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 2
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 0
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 5
  • Ubuntu 18.04 deb pkg check
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8301/artifact/TP3U1804AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 3: No useful log found
Report for rt_netlink.c | 26 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #421: FILE: /tmp/f1-1794294/rt_netlink.c:421:
< WARNING: line over 80 characters
< #1646: FILE: /tmp/f1-1794294/rt_netlink.c:1646:
< WARNING: line over 80 characters
< #1653: FILE: /tmp/f1-1794294/rt_netlink.c:1653:
< WARNING: line over 80 characters
< #1660: FILE: /tmp/f1-1794294/rt_netlink.c:1660:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-1794294/rt_netlink.c:1661:
< WARNING: line over 80 characters
< #1667: FILE: /tmp/f1-1794294/rt_netlink.c:1667:
< WARNING: line over 80 characters
< #1668: FILE: /tmp/f1-1794294/rt_netlink.c:1668:
< WARNING: line over 80 characters
< #1739: FILE: /tmp/f1-1794294/rt_netlink.c:1739:
< WARNING: line over 80 characters
< #1745: FILE: /tmp/f1-1794294/rt_netlink.c:1745:
< WARNING: line over 80 characters
< #1767: FILE: /tmp/f1-1794294/rt_netlink.c:1767:
< WARNING: line over 80 characters
< #1773: FILE: /tmp/f1-1794294/rt_netlink.c:1773:
< WARNING: line over 80 characters
< #1795: FILE: /tmp/f1-1794294/rt_netlink.c:1795:
< WARNING: line over 80 characters
< #1801: FILE: /tmp/f1-1794294/rt_netlink.c:1801:

@cscarpitta
Copy link
Contributor Author

ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Nov 10, 2022

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8302/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for rt_netlink.c | 26 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #421: FILE: /tmp/f1-2602278/rt_netlink.c:421:
< WARNING: line over 80 characters
< #1646: FILE: /tmp/f1-2602278/rt_netlink.c:1646:
< WARNING: line over 80 characters
< #1653: FILE: /tmp/f1-2602278/rt_netlink.c:1653:
< WARNING: line over 80 characters
< #1660: FILE: /tmp/f1-2602278/rt_netlink.c:1660:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-2602278/rt_netlink.c:1661:
< WARNING: line over 80 characters
< #1667: FILE: /tmp/f1-2602278/rt_netlink.c:1667:
< WARNING: line over 80 characters
< #1668: FILE: /tmp/f1-2602278/rt_netlink.c:1668:
< WARNING: line over 80 characters
< #1739: FILE: /tmp/f1-2602278/rt_netlink.c:1739:
< WARNING: line over 80 characters
< #1745: FILE: /tmp/f1-2602278/rt_netlink.c:1745:
< WARNING: line over 80 characters
< #1767: FILE: /tmp/f1-2602278/rt_netlink.c:1767:
< WARNING: line over 80 characters
< #1773: FILE: /tmp/f1-2602278/rt_netlink.c:1773:
< WARNING: line over 80 characters
< #1795: FILE: /tmp/f1-2602278/rt_netlink.c:1795:
< WARNING: line over 80 characters
< #1801: FILE: /tmp/f1-2602278/rt_netlink.c:1801:

@ton31337
Copy link
Member

@cscarpitta which one should we start reviewing, this or #12292? :)

@cscarpitta
Copy link
Contributor Author

@cscarpitta which one should we start reviewing, this or #12292? :)

@ton31337 This, thanks. I will close the other one to avoid confusion :)

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cscarpitta cscarpitta force-pushed the feature/srv6-new-fpm-support branch from ac14b05 to 84d8e94 Compare November 14, 2022 17:17
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Nov 14, 2022

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8359/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for rt_netlink.c | 26 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #421: FILE: /tmp/f1-3379033/rt_netlink.c:421:
< WARNING: line over 80 characters
< #1646: FILE: /tmp/f1-3379033/rt_netlink.c:1646:
< WARNING: line over 80 characters
< #1653: FILE: /tmp/f1-3379033/rt_netlink.c:1653:
< WARNING: line over 80 characters
< #1660: FILE: /tmp/f1-3379033/rt_netlink.c:1660:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-3379033/rt_netlink.c:1661:
< WARNING: line over 80 characters
< #1667: FILE: /tmp/f1-3379033/rt_netlink.c:1667:
< WARNING: line over 80 characters
< #1668: FILE: /tmp/f1-3379033/rt_netlink.c:1668:
< WARNING: line over 80 characters
< #1739: FILE: /tmp/f1-3379033/rt_netlink.c:1739:
< WARNING: line over 80 characters
< #1745: FILE: /tmp/f1-3379033/rt_netlink.c:1745:
< WARNING: line over 80 characters
< #1767: FILE: /tmp/f1-3379033/rt_netlink.c:1767:
< WARNING: line over 80 characters
< #1773: FILE: /tmp/f1-3379033/rt_netlink.c:1773:
< WARNING: line over 80 characters
< #1795: FILE: /tmp/f1-3379033/rt_netlink.c:1795:
< WARNING: line over 80 characters
< #1801: FILE: /tmp/f1-3379033/rt_netlink.c:1801:

@cscarpitta
Copy link
Contributor Author

Rebased to resolve merge conflicts.

Copy link
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some initial questions

FPM_NH_ENCAP_SRV6_LOCAL_SID = 102,
};

enum {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not crazy about these anonymous enums - do we have guidance about that in the dev docs?

};

enum {
SRV6_ROUTE_UNSPEC = 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put these SRV6 items here - why not in one of the srv6-specific headers?

};

enum srv6_localsid_action {
FPM_SRV6_LOCALSID_ACTION_UNSPEC = 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FPM-specific items - is this the right header for FPM?

@@ -406,6 +406,29 @@ vrf_id_t vrf_lookup_by_table(uint32_t table_id, ns_id_t ns_id)
return VRF_DEFAULT;
}

static struct zebra_vrf *vrf_lookup_by_table_id(uint32_t table_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't really care for the copy-paste of the existing function logic. can't we have one version of the logic that knows the rules for iterating through the vrfs, and then use that to return the different pieces of info? and really, that should be in the zebra_vrf module, shouldn't it?

ctx = &nexthop->nh_srv6->seg6local_ctx;

if (!nl_attr_put16(nlmsg, req_size, RTA_ENCAP_TYPE,
FPM_NH_ENCAP_SRV6_LOCAL_SID))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the design here is "pick a new encap number, and use that to contain the various tlvs with srv6 info", is that right?
is that a robust choice - will the OS-based netlink messaging never support this information? the original goal of the netlink encoded FPM messaging was to be able to use a single encoding or marshalling code-base consistently, but this sort of pushes that aside and introduces a different approach.

Copy link
Contributor Author

@cscarpitta cscarpitta Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjstapp Thanks for your review.

Yes, we pick a new encap number and we use that to contain the TLVs with SRv6 information.

I know dplane_fpm_nl is designed to share zebra's Netlink encoding functions but unfortunately we can't reuse the existing encoding functions in this case.

The reason is that the SRv6 kernel's data model is very different from the SRv6 SONiC's data model.


Let's make an example.

When we encapsulate a packet using SRv6, we add an outer IPv6 header and we need to choose an IPv6 address to use as source address in the outer IPv6 header.

This is implemented differently in the Linux kernel and in SONiC.
In the Linux kernel, we have a source address configured globally in the system and we use that address for all the SRv6 encapsulated packets. For this reason, the Netlink message used to install a route in the kernel does not contain the source address.

Instead, in SONiC each SRv6 route has its own IPv6 source address. Therefore, the Netlink message used to install an SRv6 route in SONiC must contain the source address.


This is why we need to pick a new encap number to send the SRv6 information to SONiC.

@github-actions
Copy link

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

This commit adds the `encap_src_addr` parameter to the
`struct zebra_srv6`. This parameter represents the source address of the
outer encapsulating IPv6 header. Support for configuring the
`encap_src_addr`parameter will be added in a future commit.

Signed-off-by: Carmine Scarpitta <[email protected]>
This commit prints an error message when `netlink_route_nexthop_encap()`
receives a nexthop with an unknown encap type.

Signed-off-by: Carmine Scarpitta <[email protected]>
This commit adds a new parameter `fpm` to the
`_netlink_route_build_singlepath()` function. This parameter
lets `_netlink_route_build_singlepath()` know if a route is installed
via FPM or not.

This is useful for implementing use cases where a route must be encoded
differently depending on whether it is installed via FPM or not.

Signed-off-by: Carmine Scarpitta <[email protected]>
Zebra’s `dplane_fpm_nl` module allows an external component to learn the
forwarding information computed by the FRR routing suite. Currently, the
SRv6 routes exported by the `dplane_fpm_nl` module do not include some
information such as the source address for the SRv6 encapsulation.

This commit adds the missing information to the SRv6 routes exported
by the `dplane_fpm_nl`.

Signed-off-by: Carmine Scarpitta <[email protected]>
Zebra’s `dplane_fpm_nl` module allows an external component to learn the
forwarding information computed by the FRR routing suite. Currently, the
SRv6 Local SIDs exported by the `dplane_fpm_nl` module do not include
some information such the SID format (i.e., locator block length,
locator node length, function length, and argument length).

This commit adds the missing information to the SRv6 Local SIDs exported
by the `dplane_fpm_nl`.

Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta cscarpitta force-pushed the feature/srv6-new-fpm-support branch from 84d8e94 to b1dea24 Compare June 8, 2023 07:52
@github-actions github-actions bot added the size/L label Jun 8, 2023
@cscarpitta
Copy link
Contributor Author

Rebased on master branch.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |    switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB11AMD64/config.status/config.status

Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/REDHAT8/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12115/frr-source/doc/user/nexthop_groups.rst
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/REDHAT8/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM8BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12115/frr-source/doc/user/nexthop_groups.rst
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12115/frr-source/doc/user/nexthop_groups.rst
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |    switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/RH9BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |                         switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |                         switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U22AMD64BUILD/config.status/config.status

Successful on other platforms/tests
  • CentOS 7 amd64 build
  • FreeBSD 12 amd64 build
  • OpenBSD 7 amd64 build
  • FreeBSD 11 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |    switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB11AMD64/config.status/config.status

Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/REDHAT8/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12115/frr-source/doc/user/nexthop_groups.rst
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/REDHAT8/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U18ARM8BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12115/frr-source/doc/user/nexthop_groups.rst
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12115/frr-source/doc/user/nexthop_groups.rst
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |    switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12115/frr-source'
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:4: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_S not handled in switch [-Werror=switch-enum]
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/RH9BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |                         switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12115/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/rt_netlink.c: In function _netlink_route_build_singlepath:
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_UNSPEC not handled in switch [-Werror=switch-enum]
 1764 |                         switch (nexthop->nh_srv6->seg6local_action) {
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX2 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_DX6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6 not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_B6_ENCAP not handled in switch [-Werror=switch-enum]
zebra/rt_netlink.c:1764:25: error: enumeration value ZEBRA_SEG6_LOCAL_ACTION_END_BM not handled in switch [-Werror=switch-enum]

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12115/artifact/U22AMD64BUILD/config.status/config.status

Report for rt_netlink.c | 26 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #422: FILE: /tmp/f1-304052/rt_netlink.c:422:
< WARNING: line over 80 characters
< #1736: FILE: /tmp/f1-304052/rt_netlink.c:1736:
< WARNING: line over 80 characters
< #1743: FILE: /tmp/f1-304052/rt_netlink.c:1743:
< WARNING: line over 80 characters
< #1750: FILE: /tmp/f1-304052/rt_netlink.c:1750:
< WARNING: line over 80 characters
< #1751: FILE: /tmp/f1-304052/rt_netlink.c:1751:
< WARNING: line over 80 characters
< #1757: FILE: /tmp/f1-304052/rt_netlink.c:1757:
< WARNING: line over 80 characters
< #1758: FILE: /tmp/f1-304052/rt_netlink.c:1758:
< WARNING: line over 80 characters
< #1829: FILE: /tmp/f1-304052/rt_netlink.c:1829:
< WARNING: line over 80 characters
< #1835: FILE: /tmp/f1-304052/rt_netlink.c:1835:
< WARNING: line over 80 characters
< #1857: FILE: /tmp/f1-304052/rt_netlink.c:1857:
< WARNING: line over 80 characters
< #1863: FILE: /tmp/f1-304052/rt_netlink.c:1863:
< WARNING: line over 80 characters
< #1885: FILE: /tmp/f1-304052/rt_netlink.c:1885:
< WARNING: line over 80 characters
< #1891: FILE: /tmp/f1-304052/rt_netlink.c:1891:

@github-actions github-actions bot removed the autoclose label Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cscarpitta cscarpitta closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants