lib: fix srv6 locator flags propagated to isis #15673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci:rerun |
pguibert6WIND
force-pushed
the
isis_srv6_usid
branch
from
a4cba21 to
77de4e8
Compare
pguibert6WIND
force-pushed
the
isis_srv6_usid
branch
from
77de4e8 to
f79234e
Compare
|
Can you rebase your code and re-launch de CI/CD because it is not compiled on the Bamboo CI server? |
pguibert6WIND
force-pushed
the
isis_srv6_usid
branch
from
f79234e to
c7efd5a
Compare
When usid is not used, the isis_srv6_topo1 test does not work. The SID prefix allocated by isis is different when the usid flags is set or not. When the flags is not transmitted to isis, the SID allocated is supposed to be a 128 bit mask length SID, which is not what the isis_srv6_topo1 test is supposed to obtain. Fix this by exchanging the flags locator value in the zclient api. Fixes: 9b7491e ("lib: Add support for flags to the SRv6 locator") Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
isis_srv6_usid
branch
from
c7efd5a to
03d2ad0
Compare
right. done |
cscarpitta
added a commit
to cscarpitta/sonic-buildimage
that referenced
this pull request
Dec 16, 2024
This commit brings PR FRRouting/frr#15673 from FRR mainline to SONiC lib: fix srv6 locator flags propagated to isis FRRouting/frr#15673 Signed-off-by: cscarpitta <[email protected]>
cscarpitta
added a commit
to cscarpitta/sonic-buildimage
that referenced
this pull request
Dec 16, 2024
This commit brings PR FRRouting/frr#15673 from FRR mainline to SONiC lib: fix srv6 locator flags propagated to isis FRRouting/frr#15673 Signed-off-by: cscarpitta <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
This commit brings PR FRRouting/frr#15673 from FRR mainline to SONiC lib: fix srv6 locator flags propagated to isis FRRouting/frr#15673 Signed-off-by: cscarpitta <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
This commit brings PR FRRouting/frr#15673 from FRR mainline to SONiC lib: fix srv6 locator flags propagated to isis FRRouting/frr#15673 Signed-off-by: cscarpitta <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
This commit brings PR FRRouting/frr#15673 from FRR mainline to SONiC lib: fix srv6 locator flags propagated to isis FRRouting/frr#15673 Signed-off-by: cscarpitta <[email protected]>
mssonicbld
added a commit
to mssonicbld/sonic-buildimage-msft
that referenced
this pull request
Jan 7, 2025
#### Why I did it Bring the below PRs from FRR mainline to SONiC in order to support SRv6 SID Manager in SONiC. #### New patches that were added | Patch | FRR Pull Request | | ------------- | ----------------- | | 0064-SRv6-BGP-SID-reachability.patch | FRRouting/frr#14810 | | 0065-zebra-display-srv6-encapsulation-source-address-when-configured.patch | FRRouting/frr#16151 | | 0066-lib-fix-srv6-locator-flags-propagated-to-isis.patch | FRRouting/frr#15673 | | 0067-Add-support-for-SRv6-SID-Manager.patch | FRRouting/frr#15604 | | 0068-bgpd-Extend-BGP-to-communicate-with-the-SRv6-SID-Manager-to-allocate-release-SRv6-SIDs.patch | FRRouting/frr#15676 |
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
This commit brings PR FRRouting/frr#15673 from FRR mainline to SONiC lib: fix srv6 locator flags propagated to isis FRRouting/frr#15673 Signed-off-by: cscarpitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When usid is not used, the isis_srv6_topo1 test does not work. The SID prefix allocated by isis is different when the usid flags is set or not. When the flags is not transmitted to isis, the SID allocated is supposed to be a 128 bit mask length SID, which is not what the isis_srv6_topo1 test is supposed to obtain.
Fix this by exchanging the flags locator value in the zclient api.
Fixes: 9b7491e ("lib: Add support for flags to the SRv6 locator")