Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: disable all sanitizers for clippy build #2401

Closed
wants to merge 1 commit into from
Closed

*: disable all sanitizers for clippy build #2401

wants to merge 1 commit into from

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented Jun 11, 2018 •
edited
Loading

  • Move configure flag propagations out of user flags
  • Use AC_SUBST to transfer flag values to Automake
  • Set default AM_CFLAGS and AM_CPPFLAGS in common.am and change child
    Makefiles to modify these base variables
  • Add flag override to turn off all sanitizers when building clippy
  • Remove LSAN suppressions blacklist as it's no longer needed

Fixes #2258

Signed-off-by: Quentin Young [email protected]

@qlyoung
*: disable all sanitizers for clippy build
e0fb53e 
* Move configure flag propagations out of user flags
* Use AC_SUBST to transfer flag values to Automake
* Set default AM_CFLAGS and AM_CPPFLAGS in common.am and change child
  Makefiles to modify these base variables
* Add flag override to turn off all sanitizers when building clippy
* Remove LSAN suppressions blacklist as it's no longer needed

Signed-off-by: Quentin Young <[email protected]>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 11, 2018

🛑 Basic BGPD CI results: FAILURE

Results table
_ _
Result FAILURE git merge/2401 e0fb53e frr.github Build
Date 06/11/2018
Start 15:35:10
Finish 15:35:30
Run-Time 00:20
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details vncregress-2018-06-11-15:35:10.txt
Log make-2018-06-11-15:35:10.out.bz2

For details, please contact louberger

@qlyoung qlyoung closed this Jun 11, 2018
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

FreeBSD10 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
Fedora24 amd64 build: Successful
Ubuntu 18.04 amd64 build: Successful
FreeBSD11 amd64 build: Successful
Debian9 amd64 build: Successful
OmniOS amd64 build: Successful
Ubuntu 16.04 i386: Successful

NetBSD6 amd64 build: Failed

Make failed for NetBSD6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
gmake[2]: *** [Makefile:3868: lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/home/ci/cibuild.3904/frr-source'
gmake[1]: *** [Makefile:4420: all-recursive] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.3904/frr-source'
gmake: *** [Makefile:1958: all] Error 2

NetBSD6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI007BUILD/config.status/config.status

CentOS7 amd64 build: Failed

Make failed for CentOS7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc: error: unrecognized command line option -fno-sanitize=all
gcc: error: unrecognized command line option -fno-sanitize=all
make[2]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make[1]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

CentOS7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI005BUILD/config.status/config.status

Debian8 amd64 build: Failed

Make failed for Debian8 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc-4.9.real: error: unrecognized argument to -fsanitize= option: all
gcc-4.9.real: error: unrecognized argument to -fsanitize= option: all
Makefile:3859: recipe for target 'lib/lib_clippy-clippy.o' failed
make[2]: Leaving directory '/home/ci/cibuild.3904/frr-source'
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
Makefile:4411: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/home/ci/cibuild.3904/frr-source'

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI008BLD/config.status/config.status

Ubuntu1404 amd64 build: Failed

Make failed for Ubuntu1404 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc-4.8.real: error: unrecognized command line option -fno-sanitize=all
gcc-4.8.real: error: unrecognized command line option -fno-sanitize=all
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[2]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make: *** [all] Error 2

Ubuntu1404 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI001BUILD/config.status/config.status

OpenBSD60 amd64 build: Failed

Make failed for OpenBSD60 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-Wno-unused-result"
gmake[2]: *** [Makefile:3867: lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/home/ci/cibuild.3904/frr-source'
gmake[1]: *** [Makefile:4419: all-recursive] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.3904/frr-source'

OpenBSD60 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI011BUILD/config.status/config.status

NetBSD7 amd64 build: Failed

Make failed for NetBSD7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc: error: unrecognized command line option '-fno-sanitize=all'
gcc: error: unrecognized command line option '-fno-sanitize=all'
Makefile:3868: recipe for target 'lib/lib_clippy-clippy.o' failed
gmake[2]: *** [lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/home/ci/cibuild.3904/frr-source'
Makefile:4420: recipe for target 'all-recursive' failed
gmake[1]: *** [all-recursive] Error 1

NetBSD7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI012BUILD/config.status/config.status

CentOS6 amd64 build: Failed

Make failed for CentOS6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI006BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: warning: unrecognized command line option "-Wno-unused-result"
make[2]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[1]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make[1]: *** [all-recursive] Error 1

CentOS6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI006BUILD/config.status/config.status

FreeBSD9 amd64 build: Failed

Make failed for FreeBSD9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI004BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
gmake[2]: *** [Makefile:3868: lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/usr/home/ci/cibuild.3904/frr-source'
gmake[1]: *** [Makefile:4420: all-recursive] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.3904/frr-source'
gmake: *** [Makefile:1958: all] Error 2

FreeBSD9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI004BUILD/config.status/config.status

Ubuntu1204 amd64 build: Failed

Make failed for Ubuntu1204 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI002BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option -fno-sanitize=all
cc1: error: unrecognized command line option -fno-sanitize=all
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[2]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/ci/cibuild.3904/frr-source'
make: *** [all] Error 2

Ubuntu1204 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/CI002BUILD/config.status/config.status

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3904/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: shared-lib-without-dependency-information usr/lib/libfrrfpm_pb.so.0.0.0
N: 6 tags overridden (5 warnings, 1 info)

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

FreeBSD10 amd64 build: Successful
OmniOS amd64 build: Successful
Debian9 amd64 build: Successful
Fedora24 amd64 build: Successful
FreeBSD11 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
Ubuntu 18.04 amd64 build: Successful
Ubuntu 16.04 i386: Successful

CentOS7 amd64 build: Failed

Make failed for CentOS7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc: error: unrecognized command line option -fno-sanitize=all
gcc: error: unrecognized command line option -fno-sanitize=all
make[2]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make[1]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

CentOS7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI005BUILD/config.status/config.status

Ubuntu1404 amd64 build: Failed

Make failed for Ubuntu1404 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc-4.8.real: error: unrecognized command line option -fno-sanitize=all
gcc-4.8.real: error: unrecognized command line option -fno-sanitize=all
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[2]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make: *** [all] Error 2

Ubuntu1404 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI001BUILD/config.status/config.status

Debian8 amd64 build: Failed

Make failed for Debian8 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc-4.9.real: error: unrecognized argument to -fsanitize= option: all
gcc-4.9.real: error: unrecognized argument to -fsanitize= option: all
Makefile:3859: recipe for target 'lib/lib_clippy-clippy.o' failed
make[2]: Leaving directory '/home/ci/cibuild.3905/frr-source'
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
Makefile:4411: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/home/ci/cibuild.3905/frr-source'

Debian8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI008BLD/config.status/config.status

OpenBSD60 amd64 build: Failed

Make failed for OpenBSD60 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-Wno-unused-result"
gmake[2]: *** [Makefile:3867: lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/home/ci/cibuild.3905/frr-source'
gmake[1]: *** [Makefile:4419: all-recursive] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.3905/frr-source'

OpenBSD60 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI011BUILD/config.status/config.status

NetBSD7 amd64 build: Failed

Make failed for NetBSD7 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
gcc: error: unrecognized command line option '-fno-sanitize=all'
gcc: error: unrecognized command line option '-fno-sanitize=all'
Makefile:3868: recipe for target 'lib/lib_clippy-clippy.o' failed
gmake[2]: *** [lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/home/ci/cibuild.3905/frr-source'
Makefile:4420: recipe for target 'all-recursive' failed
gmake[1]: *** [all-recursive] Error 1

NetBSD7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI012BUILD/config.status/config.status

NetBSD6 amd64 build: Failed

Make failed for NetBSD6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
gmake[2]: *** [Makefile:3868: lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/home/ci/cibuild.3905/frr-source'
gmake[1]: *** [Makefile:4420: all-recursive] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.3905/frr-source'
gmake: *** [Makefile:1958: all] Error 2

NetBSD6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI007BUILD/config.status/config.status

CentOS6 amd64 build: Failed

Make failed for CentOS6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI006BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: warning: unrecognized command line option "-Wno-unused-result"
make[2]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[1]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make[1]: *** [all-recursive] Error 1

CentOS6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI006BUILD/config.status/config.status

FreeBSD9 amd64 build: Failed

Make failed for FreeBSD9 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI004BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option "-fno-sanitize=all"
cc1: error: unrecognized command line option "-fno-sanitize=all"
gmake[2]: *** [Makefile:3868: lib/lib_clippy-clippy.o] Error 1
gmake[2]: Leaving directory '/usr/home/ci/cibuild.3905/frr-source'
gmake[1]: *** [Makefile:4420: all-recursive] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.3905/frr-source'
gmake: *** [Makefile:1958: all] Error 2

FreeBSD9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI004BUILD/config.status/config.status

Ubuntu1204 amd64 build: Failed

Make failed for Ubuntu1204 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI002BUILD/ErrorLog/log_make.txt)

  CC       ospfd/ospf_te.o
  CC       lib/lib_clippy-clippy.o
cc1: error: unrecognized command line option -fno-sanitize=all
cc1: error: unrecognized command line option -fno-sanitize=all
make[2]: *** [lib/lib_clippy-clippy.o] Error 1
make[2]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/ci/cibuild.3905/frr-source'
make: *** [all] Error 2

Ubuntu1204 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/CI002BUILD/config.status/config.status

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3905/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: shared-lib-without-dependency-information usr/lib/libfrrfpm_pb.so.0.0.0
N: 6 tags overridden (5 warnings, 1 info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qlyoung @LabN-CI @NetDEF-CI