Build F* with sedlex 2.4 #2388
Merged
Build F* with sedlex 2.4 #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you @toots for your insights from #2343 (comment)
|
thanks! this is great and solves some install brittleness that many people have reported. |
Closed
tahina-pro
added a commit
to project-everest/everest
that referenced
this pull request
Nov 9, 2021
This reverts commit 7440073 thanks to FStarLang/FStar#2388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2343: F* has long not built with sedlex 2.4.
As @toots pointed out at #2343 (comment) , we are actually "replacing" sedlex's
Sedlexingmodule with our ownsrc/parser/ml/FStar_Sedlexing.ml, namely by:FStar/src/parser/ml/FStar_Parser_LexFStar.ml
Line 7 in 2b830a4
There, I noticed that
__private__next_intwas not defined in ourFStar_Sedlexing, but the lexer implementation generated by sedlex 2.4 does use that function. So I add it in this PR.With this PR,
docker build --pull --file .docker/opam.Dockerfile .successfully builds a Docker image that installs sedlex 2.4, builds F* against it, and run all F* regression tests.Thank you Romain for your insights!