Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/pydantic #143

Closed
wants to merge 31 commits into from
Closed

Refactor/pydantic #143

wants to merge 31 commits into from

Conversation

xgui3783
Copy link
Member

@xgui3783 xgui3783 commented Dec 6, 2021

No description provided.

chore: clarify and rename parse_alias method
chore: reworked concept.matches
chore: reworked Parcellation.decode_region method
chore: reworked Region.find
tests: structured tests
feat: refactored ebrains dataset
chore: minor revision of SiibraNode.find. it now returns List[SiibraNode]
chore: minor revision of connectviity feature
chore: minor revision of receptor feature
test: parc should have > 0 atlases
test: Region._parcellation should be defined
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #143 (4f91442) into main (f9fd6bc) will decrease coverage by 8.02%.
The diff coverage is 41.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   48.86%   40.83%   -8.03%     
==========================================
  Files          27      108      +81     
  Lines        3121     4697    +1576     
==========================================
+ Hits         1525     1918     +393     
- Misses       1596     2779    +1183     
Impacted Files Coverage Δ
siibra/openminds/SANDS/v3/atlas/atlasAnnotation.py 0.00% <0.00%> (ø)
...penminds/SANDS/v3/atlas/parcellationTerminology.py 0.00% <0.00%> (ø)
...s/SANDS/v3/atlas/parcellationTerminologyVersion.py 0.00% <0.00%> (ø)
.../v3/miscellaneous/qualitativeRelationAssessment.py 0.00% <0.00%> (ø)
...v3/miscellaneous/quantitativeRelationAssessment.py 0.00% <0.00%> (ø)
...openminds/controlledTerms/v1/UBERONParcellation.py 0.00% <0.00%> (ø)
...a/openminds/controlledTerms/v1/actionStatusType.py 0.00% <0.00%> (ø)
siibra/openminds/controlledTerms/v1/ageCategory.py 0.00% <0.00%> (ø)
...ds/controlledTerms/v1/anatomicalAxesOrientation.py 0.00% <0.00%> (ø)
...ra/openminds/controlledTerms/v1/biologicalOrder.py 0.00% <0.00%> (ø)
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fd6bc...4f91442. Read the comment docs.

@xgui3783
Copy link
Member Author

superceded by #154

@xgui3783 xgui3783 closed this Jan 25, 2022
@xgui3783 xgui3783 deleted the refactor/pydantic branch February 23, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants