add tests to all connectivity features (many are buggy) #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 57.38% 60.71% +3.33%
==========================================
Files 32 32
Lines 4301 4343 +42
==========================================
+ Hits 2468 2637 +169
+ Misses 1833 1706 -127
Continue to review full report at Codecov.
|
rather than use tmpfile, now uses BytesIO. tmpfile does not seem to be managed by CACHE & maxsize, and can grow infinitely in size. The test suite in test_connectivity, for example, fills tempdir with multiple 400mb zip files, and are not managed or removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.