Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend pydantic model #163

Merged
merged 1 commit into from
Mar 8, 2022
Merged

extend pydantic model #163

merged 1 commit into from
Mar 8, 2022

Conversation

xgui3783
Copy link
Member

@xgui3783 xgui3783 commented Mar 8, 2022

add type field to connectivity response
add modality field to parcellation

add modality field to parcellation
@codecov-commenter
Copy link

Codecov Report

Merging #163 (cf49c3f) into main (2885fc1) will increase coverage by 0.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   59.77%   60.75%   +0.98%     
==========================================
  Files          32       32              
  Lines        4348     4350       +2     
==========================================
+ Hits         2599     2643      +44     
+ Misses       1749     1707      -42     
Impacted Files Coverage Δ
siibra/core/parcellation.py 76.85% <100.00%> (+0.10%) ⬆️
siibra/features/connectivity.py 92.09% <100.00%> (+19.19%) ⬆️
siibra/core/serializable_concept.py 94.28% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2885fc1...cf49c3f. Read the comment docs.

@xgui3783 xgui3783 merged commit b0857f4 into main Mar 8, 2022
@xgui3783 xgui3783 deleted the feat_extendModel branch March 8, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants