-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maint sparseindex #525
Maint sparseindex #525
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
+ Coverage 46.00% 46.02% +0.02%
==========================================
Files 75 75
Lines 7232 7165 -67
==========================================
- Hits 3327 3298 -29
+ Misses 3905 3867 -38 ☔ View full report in Codecov by Sentry. |
c1b266c
to
ecc1a42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an issue with the name of the files and how decoders are found. Others looks solid.
2bbae34
to
3c157a7
Compare
…rl not sparseindex, use sparse index only for volume assignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check all code but it looks reasonable to me. once merged we need to test thoroughly that probabilistic assignment behaves identical to previous versions, especially using the tutorial notebooks that do assignment.
TODO: