Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint sparseindex #525

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Maint sparseindex #525

merged 8 commits into from
Dec 6, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek commented Dec 15, 2023

TODO:

  • create a data proxy folder for version 1 specifically
  • regions should be fetchable without forming sparseindex. use sparse index for assignments only

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: Patch coverage is 40.74074% with 48 lines in your changes missing coverage. Please review.

Project coverage is 46.02%. Comparing base (dc63457) to head (d23a2b8).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
siibra/volumes/sparsemap.py 41.53% 38 Missing ⚠️
siibra/retrieval/repositories.py 28.57% 5 Missing ⚠️
siibra/retrieval/requests.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   46.00%   46.02%   +0.02%     
==========================================
  Files          75       75              
  Lines        7232     7165      -67     
==========================================
- Hits         3327     3298      -29     
+ Misses       3905     3867      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Jan 11, 2024
@AhmetNSimsek AhmetNSimsek force-pushed the maint_sparseindex branch 2 times, most recently from c1b266c to ecc1a42 Compare January 24, 2024 13:30
@AhmetNSimsek AhmetNSimsek requested a review from xgui3783 January 24, 2024 13:31
Copy link
Member

@xgui3783 xgui3783 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an issue with the name of the files and how decoders are found. Others looks solid.

siibra/retrieval/requests.py Outdated Show resolved Hide resolved
siibra/retrieval/requests.py Outdated Show resolved Hide resolved
@AhmetNSimsek AhmetNSimsek marked this pull request as ready for review January 25, 2024 11:35
@AhmetNSimsek AhmetNSimsek marked this pull request as draft November 6, 2024 18:36
@AhmetNSimsek AhmetNSimsek marked this pull request as ready for review November 12, 2024 15:07
Copy link
Contributor

@dickscheid dickscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check all code but it looks reasonable to me. once merged we need to test thoroughly that probabilistic assignment behaves identical to previous versions, especially using the tutorial notebooks that do assignment.

siibra/volumes/sparsemap.py Show resolved Hide resolved
@AhmetNSimsek AhmetNSimsek merged commit 66f5866 into main Dec 6, 2024
38 of 39 checks passed
@AhmetNSimsek AhmetNSimsek deleted the maint_sparseindex branch December 6, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants